exclude example app from release profile #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on nexus-staging-maven-plugin it appears that plugin may not release the artifacts if last module (in our case example app) has it disabled. As I workaround I created defaultBuild profile (active by default) that includes example app but if any other profile is specified (e.g. -P release) then default one will be automatically disabled. This will allow us to release only schema generator module.
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
Coverage 96.82% 96.82%
Complexity 196 196
=========================================
Files 61 61
Lines 694 694
Branches 124 124
=========================================
Hits 672 672
Misses 9 9
Partials 13 13Continue to review full report at Codecov.
|
tapaderster
approved these changes
Jul 22, 2019
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 11, 2019
Based on nexus-staging-maven-plugin it appears that plugin may not release the artifacts if last module (in our case example app) has it disabled. As I workaround I created defaultBuild profile (active by default) that includes example app but if any other profile is specified (e.g. -P release) then default one will be automatically disabled. This will allow us to release only schema generator module.
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Based on nexus-staging-maven-plugin it appears that plugin may not release the artifacts if last module (in our case example app) has it disabled. As I workaround I created defaultBuild profile (active by default) that includes example app but if any other profile is specified (e.g. -P release) then default one will be automatically disabled. This will allow us to release only schema generator module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on nexus-staging-maven-plugin it appears that plugin may not release the artifacts if last module (in our case example app) has it disabled. As I workaround I created defaultBuild profile (active by default) that includes example app but if any other profile is specified (e.g. -P release) then default one will be automatically disabled. This will allow us to release only schema generator module.