You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The LongIdGenerator was introduced in commit #b93f6685 however there are still numerous places in the code that assume that traceId is a UUID:
For example in the TextMapPropagator#extract(TextMap carrier) method the following code exists (which assumes the traceId, spanId and parentId are all UUID's):
When the LongIdGenerator is used (in a client) the following error occurs:
Error handling a request: 9747e8d6c092bd0b
! java.lang.IllegalArgumentException: Invalid UUID string: 1560033070049436460
! at java.util.UUID.fromString(UUID.java:194)
! at com.expedia.www.haystack.client.propagation.TextMapPropagator.extract(TextMapPropagator.java:101)
! at com.expedia.www.haystack.client.propagation.TextMapPropagator.extract(TextMapPropagator.java:30)
! at com.expedia.www.haystack.client.Tracer.extract(Tracer.java:185)
! at com.expedia.www.haystack.client.Tracer.extract(Tracer.java:43)
! at io.opentracing.contrib.jaxrs2.server.ServerTracingFilter.parentSpanContext(ServerTracingFilter.java:99)
! at io.opentracing.contrib.jaxrs2.server.ServerTracingFilter.filter(ServerTracingFilter.java:68)
! at org.glassfish.jersey.server.ContainerFilteringStage.apply(ContainerFilteringStage.java:132)
<snip>
The
LongIdGenerator
was introduced in commit #b93f6685 however there are still numerous places in the code that assume thattraceId
is aUUID
:For example in the
TextMapPropagator#extract(TextMap carrier)
method the following code exists (which assumes thetraceId
,spanId
andparentId
are allUUID
's):When the
LongIdGenerator
is used (in a client) the following error occurs:This can be easily replicated by running the example in https://github.com/ExpediaDotCom/haystack-dropwizard-example
There is also a reference to
UUID.randomUUID()
on Line 327 in Tracer.java which should be replaced bytracer.idGenerator.generate()
The text was updated successfully, but these errors were encountered: