Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add option to delete Insight from IEX but keep GH repository #824

Merged
merged 3 commits into from
May 11, 2022

Conversation

LulaV14
Copy link
Member

@LulaV14 LulaV14 commented May 6, 2022

This PR addresses adding an extra option when deleting an Insight to delete and keep the GH repository untouched or delete the Insight and archived the GH repository.

image

@LulaV14 LulaV14 requested a review from a team as a code owner May 6, 2022 18:36
Copy link
Contributor

@baumandm baumandm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about inverting the actions to avoid the negative, e.g. Delete and Delete and Archive. That makes it more clear what is going to happen.

@LulaV14 LulaV14 requested a review from baumandm May 9, 2022 17:46
Copy link
Contributor

@baumandm baumandm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LulaV14 LulaV14 merged commit 0baf7c7 into main May 11, 2022
@LulaV14 LulaV14 deleted the feature/remove-insight-from-iex branch May 11, 2022 15:14
eg-oss-ci added a commit that referenced this pull request May 11, 2022
### [3.13.2](v3.13.1...v3.13.2) (2022-05-11)

### Bug Fixes

* Add option to delete Insight from IEX but keep GH repository ([#824](#824)) ([0baf7c7](0baf7c7))
* **deps:** bump luxon and @types/luxon ([26e22d8](26e22d8))
* Disable Zoom feature for tables on Markdown files to have links clickable ([37ae7c3](37ae7c3))
@eg-oss-ci
Copy link
Contributor

🎉 This PR is included in version 3.13.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants