Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11768] Web- Chat - Transition using the back button does not work correctly #10409

Closed
kbecciv opened this issue Aug 16, 2022 · 32 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Planning Changes still in the thought process
Projects

Comments

@kbecciv
Copy link

kbecciv commented Aug 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with an account that has multiple chats
  3. Open any chat
  4. Open a different chat
  5. And any other again
  6. Click the browser's back button

Expected Result:

The transition back must be consecutive in the reverse order

Actual Result:

Transition using the back button does not work correctly

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.88.13

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5691702_Recording__1505.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Aug 16, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@AndrewGable
Copy link
Contributor

Seems like this happens on production, so I don't think it should be a deploy blocker.

@AndrewGable AndrewGable added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 23, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 1, 2022
@marcaaron
Copy link
Contributor

I am pretty sure this is a duplicate and related to some issues we have that are on hold so going to put this one on HOLD as well.

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2022
@marcaaron marcaaron changed the title Web- Chat - Transition using the back button does not work correctly [HOLD] Web- Chat - Transition using the back button does not work correctly Sep 4, 2022
@marcaaron marcaaron added Internal Requires API changes or must be handled by Expensify staff Planning Changes still in the thought process labels Sep 4, 2022
@marcaaron marcaaron added this to HOLD in Navigation Sep 4, 2022
@marcaaron marcaaron removed their assignment Sep 4, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 labels Oct 18, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@JmillsExpensify
Copy link

Still held on the larger navigation re-write.

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@JmillsExpensify
Copy link

Still on hold for navigation.

@JmillsExpensify JmillsExpensify added Monthly KSv2 and removed Weekly KSv2 labels Dec 19, 2022
@JmillsExpensify
Copy link

Still on hold for navigation. No ETA.

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@JmillsExpensify
Copy link

Same same.

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 17, 2023
@JmillsExpensify
Copy link

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 29, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@JmillsExpensify
Copy link

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@JmillsExpensify
Copy link

Coming off hold very soon!

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@JmillsExpensify
Copy link

Working on testing this week.

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@JmillsExpensify
Copy link

Still trying to make time. Low priority.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@JmillsExpensify
Copy link

The transition back must be consecutive in the reverse order

Just re-tested and this works perfectly!

@JmillsExpensify
Copy link

Reported by QA so nothing due for issue reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Planning Changes still in the thought process
Projects
Development

No branches or pull requests

7 participants