Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Conversation - Edited comment doesn't appear greyed out #10766

Closed
kbecciv opened this issue Sep 1, 2022 · 7 comments
Closed

mWeb - Conversation - Edited comment doesn't appear greyed out #10766

kbecciv opened this issue Sep 1, 2022 · 7 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Sep 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #9532

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
    and login with any account
  2. Add a comment to a report
  3. Go offline
  4. Edit the comment that was created
  5. Verify the edited comment appears greyed out

Comment:

Issue reproduced occasionally

Expected Result:

The edited comment appears greyed out.

Actual Result:

The edited comment doesn't appear greyed out.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.96.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5713767_Record_2022-09-01-18-22-42.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2022

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title mWeb - Conversation - Edited comment doesn't appears greyed out mWeb - Conversation - Edited comment doesn't appear greyed out Sep 1, 2022
@PauloGasparSv
Copy link
Contributor

Just tested this on my phone and it seems to work! Maybe this is specific to a browser/platform:

WhatsApp.Video.2022-09-02.at.10.22.07.AM.mp4

@PauloGasparSv
Copy link
Contributor

I think this may be an emulator problem because the global offline indicator is not appearing in the this issue's video! And it should appear alongside the browser/phone top bar indicator when the app goes offline.
image

@techievivek
Copy link
Contributor

@PauloGasparSv I agree with you, I don't know why it didn't listen for the offline event. Please feel free to assign yourself to it if you want to work on it otherwise I will apply the external label.

@PauloGasparSv
Copy link
Contributor

@techievivek I'm not sure if that's a bug 😄
I think that's just a prob with the emulator, sometimes I have to turn off the internet on my computer itself so the app goes offline for real.
Testing on my device it was working ok : )
Do you mind checking if this is working on your environment? Cause if so, I think we can close this one.

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2022
@techievivek
Copy link
Contributor

I am down with a fever today, I will check it tomorrow once I come online. Thanks

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 6, 2022
@techievivek
Copy link
Contributor

I tested this locally and doesn't seem like it's an issue. Also, as @PauloGasparSv mentioned this is something particular to the emulator so I am closing this one for now.

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants