[HOLD for payment 2023-01-11] IOS - Workspace -Units under Reimbursement-hidden by keyboard after tap on it (small phones)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Go to Setting - Workspace
4. Tap on Reimbursable expenses
5. Tap on Units to change it

Expected Result:

Units under Reimbursement should be visible after tap on it

Actual Result:

Units under Reimbursement-hidden by keyboard after tap on it

Workaround:

Unknow

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1664396449.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @AndrewGable is eligible for the External assigner, not assigning anyone new.

[JmillsExpensify]

Putting a hold on this and filing with our larger keyboard initiative.

[melvin-bot]

@JmillsExpensify, @AndrewGable, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

Moved to weekly while issue is on hold pending larger keyboard updates.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[AndrewGable]

Ok two weeks of not being able to reproduce means I think we should close, reopen if you disagree!

[kbecciv]

@JmillsExpensify @AndrewGable QA team is discovered the same issue in Android on build 1.2.17.0

Record_2022-10-18-11-09-02_4f9154176b47c00da84e32064abf1c48.mp4

[tgolen]

I'd still like to get a better idea of what the proposal would look like, but if @chrispader just wants to work in the PR to iron out the details, that's fine with me too.

[chrispader]

@JmillsExpensify @tgolen added a PR for this. in Expensify/App

The changes in react-native-picker-select i would like to submit to the general library, once it got reviewed here

[JmillsExpensify]

I wanted to give everyone a quick heads up that I'm OOO this week, though I intend to check in every couple of days. @tgolen if you need anything quickly on the Bug Zero side of things, it'd be great if you can handle it or raise it #bug-zero in Slack for help. Thanks!

[tgolen]

There will be three PRs for this issue:

1. A PR to the Expensify fork of react-native-picker-select. IN REVIEW
2. A PR to App to implement the new features of the picker. IN REVIEW
3. A PR to the official react-native-picker-select upstream library. PENDING

It sounds like 3 will be done after we have completed 1 and 2, is that right @chrispader ?

[chrispader]

Yes, exactly! @tgolen

Working on both of these PRs (1 & 2) right now

[JmillsExpensify]

Circling back on 3, do we have a separate issue for that, or we're going to hold off closing this issue until all three PRs are merged (either in this repo or upstream)?

[melvin-bot]

@JmillsExpensify, @tgolen, @hannojg, @chrispader, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Looks like we are still working through #13514, which @parasharrajat was able to review today. Woo! That said, most everyone on this issue is out for the holidays, so I'm moving this issue to weekly and we can resume daily updates next week.

[chrispader]

I think this issue is already fixed, right? @tgolen @JmillsExpensify

[tgolen]

For the most part, yes. Did we ever do this?

A PR to the official react-native-picker-select upstream library.

[chrispader]

I added a PR in the upstream library. You can find it here

[JmillsExpensify]

Great point. So I think in that case, we need to:

• Add the BugZero checklist to this issue ✅
• Create an issue to revert our rn-picker fork when the PR is merged upstream
• So at this point we just need to close out the checklist and then issue payments.

[JmillsExpensify]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @tgolen] The PR that introduced the bug has been identified. Link to the PR: No PR. This wasn't a regression and was just adding a feature that didn't exist
• [@parasharrajat / @tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat / @tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[JmillsExpensify]

Circling back to payments, this is where I think we landed.

• Issue reporter: N/A
• Contributor: @chrispader $1,000
• Contributor+: @parasharrajat $1,000

@parasharrajat the upwork job is here: https://www.upwork.com/jobs/~014479aca2e5c69cc7. @chrispader I think Margelo is adding these to the monthly invoice, so make sure you pass the word along.

[JmillsExpensify]

@parasharrajat @tgolen Do both of you mind giving us a head start on the BZ checklist above?

[tgolen]

Sure, this one is easy since it wasn't a regression. It was just something missing from the original implementation (so technically we added a feature).

[JmillsExpensify]

@parasharrajat Let's close the loop on this one. I've gone ahead and invited you to the Upwork job.

[JmillsExpensify]

P.S. Regression issue is created, so we'll be ready to close this out as soon as Rajat is able to accept.

[JmillsExpensify]

@parasharrajat has been paid out, so we should be done here. Thanks!