Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold #11768] mWeb- Connect Bank Account - Pressing back button at android in the middle of a step takes you back to the workspace page instead of going back to the previous step @Puneet-here #11429

Closed
kbecciv opened this issue Sep 29, 2022 · 45 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2
Projects

Comments

@kbecciv
Copy link

kbecciv commented Sep 29, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com and log in
  2. Go to bank account > add info > company step
  3. Press back button of mobile

Expected Result:

ou should be navigated back to the previous step

Actual Result:

You will be navigated to the workspace page

Workaround:

Unknow

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-09-22.at.2.04.27.AM.mov

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663792588717789

View all open jobs on GitHub

@kbecciv kbecciv added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2022

Triggered auto assignment to @joekaufmanexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@joekaufmanexpensify
Copy link
Contributor

I don't have an android phone, but worked with @pecanoro to reproduce this in an android device.

@joekaufmanexpensify
Copy link
Contributor

Discussing ideal behavior for how this should work here.

@joekaufmanexpensify
Copy link
Contributor

In the meantime, going to pass to engineering to review. Also, based on this post, whatever solution we do decide on is going to be on hold pending completion of this issue.

@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MariaHCD
Copy link
Contributor

MariaHCD commented Oct 3, 2022

Demoting priority and adding to project: https://github.com/Expensify/App/projects/2

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2022
@MariaHCD MariaHCD added Monthly KSv2 and removed Daily KSv2 labels Oct 3, 2022
@MariaHCD MariaHCD added this to HOLD in Navigation Oct 3, 2022
@MariaHCD MariaHCD removed their assignment Oct 3, 2022
@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 labels Oct 18, 2022
@tjferriss
Copy link
Contributor

I'm not able to reproduce this on web staging (v1.2.18-2) or on my iPhone app (v1.2.15-3). I am successfully taken back to the previous step. Are we sure this is still broken?

@Puneet-here
Copy link
Contributor

Hi @tjferriss, it's still reproducible. You have to repro this on Android and you will need to press native back button.

@JmillsExpensify
Copy link

Still on hold for the navigation reboot.

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@JmillsExpensify
Copy link

Same same

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 17, 2023
@JmillsExpensify
Copy link

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 29, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@JmillsExpensify
Copy link

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@JmillsExpensify
Copy link

Coming off hold very soon!

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@JmillsExpensify
Copy link

Working on testing this week.

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@JmillsExpensify
Copy link

Still trying to make time. Low priority.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@JmillsExpensify
Copy link

@Puneet-here do you mind re-testing this one and confirming that it's no longer an issue? At that point we can pay you for reporting the issue.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@Puneet-here
Copy link
Contributor

It's still reproducible.

@JmillsExpensify
Copy link

Thanks! @mountiny is the BBA flow potentially a special case that we didn't cover for the react-navigation project? Perhaps just as relevant: What's the expected behavior for a multi-step flow in a modal? Just thinking generally on this, I'm kind of doubting that each step has it's own route, and thus back would correctly close the modal.

@mountiny
Copy link
Contributor

Yeah this is because each step is most likely not its own screen. I think however we can close this since this project will probably change this completely https://docs.google.com/document/d/1t8_Fn93LSSU4gG4z7WRt8IFcpSGK4TIe4QamdcTXjxE/edit?usp=sharing

@JmillsExpensify
Copy link

Ok cool. I'll still go ahead and pay out @Puneet-here for reporting, since we will fix this.

@JmillsExpensify
Copy link

Offer sent. Please accept and we can get this closed out @Puneet-here!

@Puneet-here
Copy link
Contributor

Accepted!

@JmillsExpensify
Copy link

All paid out! Thank you, have a great weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2
Projects
Development

No branches or pull requests

8 participants