Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [$250] mWeb- LHN - Forward arrow doesn't work when pressed again #12203

Closed
kbecciv opened this issue Oct 27, 2022 · 13 comments
Closed

[HOLD] [$250] mWeb- LHN - Forward arrow doesn't work when pressed again #12203

kbecciv opened this issue Oct 27, 2022 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 27, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

1 Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Navigate to any conversation
4. Write something and send
3. Return to LHN
4. Press forward arrow
5. Go back again to LHN
6. Forward arrow again

Expected Result:

The user should be able to return to the chat using the arrow.

Actual Result:

Forward arrow doesn't work when pressed again

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web/Safari

Version Number: 1.2.20.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5795076_2022_10_27_18_13_Img_8040.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Engineering Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dylanexpensify
Copy link
Contributor

@dylanexpensify dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Oct 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title mWeb- LHN - Forward arrow doesn't work when pressed again [$250] mWeb- LHN - Forward arrow doesn't work when pressed again Oct 28, 2022
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Oct 28, 2022
@mountiny mountiny changed the title [$250] mWeb- LHN - Forward arrow doesn't work when pressed again [HOLD] [$250] mWeb- LHN - Forward arrow doesn't work when pressed again Oct 28, 2022
@mountiny
Copy link
Contributor

Putting this on HOLD, i think this should be part of #11768

@mountiny
Copy link
Contributor

Alright, looking into this I am not that sure this is a real issue though. I dont think we would expect you to press the forward multiple times and it does not break the app so I think this is do-nothing. What do you think @JmillsExpensify?

@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2022
@dylanexpensify
Copy link
Contributor

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Nov 7, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 16, 2022
@dylanexpensify
Copy link
Contributor

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Nov 16, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2022
@mountiny
Copy link
Contributor

Still on hold for the navigation reboot. I will make this monthly as there is probably no action here until the navigation is updated

@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 25, 2022

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@mountiny mountiny added Monthly KSv2 and removed Weekly KSv2 labels Nov 25, 2022
@JmillsExpensify
Copy link

Alright, looking into this I am not that sure this is a real issue though. I don't think we would expect you to press the forward multiple times and it does not break the app so I think this is do-nothing. What do you think @JmillsExpensify?

@vitHoracek I seem to have missed this notification earlier, though I agree that we should close – because as you mention, this is quite an edge case, and then related, we're already addressing this as part of react navigation. I'd recommend we close but still link to the react navigation issue. I'll do both now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants