Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-23] [$1000] Search page shows blank list after login while trying to open that deeplink url reported by @0xmiroslav #12717

Closed
kavimuru opened this issue Nov 14, 2022 · 37 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

kavimuru commented Nov 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Logout if already logged in
  2. Visit https://new.expensify.com/search
  3. Login with any account

Expected Result:

Search page shows with contacts list

Actual Result:

Search page shows but no content

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.27-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.930.mp4
bug.mov

Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668427738763249

View all open jobs on GitHub

Upwork Automation - Do Not Edit

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 14, 2022

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@tjferriss
Copy link
Contributor

I was able to pull up the search with contact list. However I did get an error message before this. @kavimuru are you still able to reproduce this one?

Screen.Recording.2022-11-15.at.2.14.48.PM.mov

@kavimuru
Copy link
Author

@tjferriss I'm still able to reproduce

Recording.939.mp4

@0xmiroslav
Copy link
Contributor

I was able to pull up the search with contact list. However I did get an error message before this. @kavimuru are you still able to reproduce this one?

Screen.Recording.2022-11-15.at.2.14.48.PM.mov

@tjferriss it seems crashed when login with your specific account. can you please share console error?

@tjferriss
Copy link
Contributor

Here you go:
Screen Shot 2022-11-15 at 2 39 48 PM

react-dom.production.min.js:186 TypeError: Cannot read properties of undefined (reading 'replace')
    at Object.removeSMSDomain (str.js:934:21)
    at S (OptionsListUtils.js:351:19)
    at OptionsListUtils.js:499:31
    at Function.zt (each.js:14:7)
    at w (OptionsListUtils.js:483:5)
    at Object.H (OptionsListUtils.js:650:12)
    at new I (SearchPage.js:60:13)
    at bi (react-dom.production.min.js:140:172)
    at Fl (react-dom.production.min.js:216:146)
    at yc (react-dom.production.min.js:291:286)
ll @ react-dom.production.min.js:186
gestureStateManager.ts:22 Uncaught Error: No handler for tag 3
    at Q (NodeManager.ts:12:9)
    at Object.updateGestureHandler (RNGestureHandlerModule.web.ts:108:7)
    at GestureDetector.tsx:181:7
    at e.exports (_invoke.js:5:25)
    at C.<computed> (_task.js:35:7)
    at Number.A (_task.js:21:5)
    at MessagePort.h (_task.js:25:7)
search:1          Failed to load resource: the server responded with a status of 404 ()

@0xmiroslav
Copy link
Contributor

@tjferriss What is version number? It seems you're checking on old version
Latest production version is v1.2.27-4

@JmillsExpensify
Copy link

Looking at the video, it looks like the bug is more accurately that we're showing a blank list while loading, rather than persisting a spinner while that same list is being loaded. In fact, the results show up at the end of that video, right?

@tjferriss
Copy link
Contributor

I'm on v1.2.28-2

@0xmiroslav
Copy link
Contributor

@tjferriss can you also try with another account? It might be account specific issue.
I just tested on latest staging (v1.2.28-2) but not able to reproduce that crash

@tjferriss
Copy link
Contributor

Ok I was finally able to replicate this when in incognito so I'm going to add the External tag to get us started.

However, I also read up on the referenced bug issue, it looks like there might be a wider solution for these types of issues being discussed there.

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2022
@tjferriss tjferriss added the External Added to denote the issue can be worked on by a contributor label Nov 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

Job added to Upwork: https://www.upwork.com/jobs/~015549ad320d83033c

@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

Triggered auto assignment to @mountiny (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Search page shows blank list after login while trying to open that deeplink url reported by @0xmiroslav [$1000] Search page shows blank list after login while trying to open that deeplink url reported by @0xmiroslav Nov 21, 2022
@mountiny mountiny changed the title [$1000] Search page shows blank list after login while trying to open that deeplink url reported by @0xmiroslav [HOLD #11768] [$1000] Search page shows blank list after login while trying to open that deeplink url reported by @0xmiroslav Nov 21, 2022
@mountiny
Copy link
Contributor

Putting this on hold for the navigation refactor as also Rajat mentione this seems like an issue with react-navigation #11768

@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Nov 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@mountiny
Copy link
Contributor

on hold

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2023
@JmillsExpensify
Copy link

Thanks @mountiny. Still working on clearing a super long GH backlog, should be in good shape for the next time around. 🙌🏼

@melvin-bot melvin-bot bot added the Overdue label May 19, 2023
@JmillsExpensify
Copy link

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2023
@0xmiroslav
Copy link
Contributor

This was fixed in #14490 and not reproducible anymore.
Can I get reporting bonus and close the issue?

@mountiny mountiny added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels May 22, 2023
@mountiny mountiny changed the title [HOLD #11768] [$1000] Search page shows blank list after login while trying to open that deeplink url reported by @0xmiroslav [HOLD for payment 2023-05-23] [$1000] Search page shows blank list after login while trying to open that deeplink url reported by @0xmiroslav May 22, 2023
@mountiny
Copy link
Contributor

mountiny commented May 22, 2023

Lets do that, cc @JmillsExpensify

@melvin-bot melvin-bot bot added the Overdue label May 25, 2023
@mountiny
Copy link
Contributor

Jason is ooo, reassinging to handle the payments

@melvin-bot melvin-bot bot removed the Overdue label May 26, 2023
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@mountiny
Copy link
Contributor

Reporting bonus of $250 is due for @0xmiroslav thanks @twisterdotcom

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Daily KSv2 labels May 29, 2023
@twisterdotcom
Copy link
Contributor

@twisterdotcom
Copy link
Contributor

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

7 participants