[HOLD for payment 2023-02-03] Invite members: very little space between the lines and the highlighted lines are overlapping

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > manage members
2. Click invite button
3. Select the text at add a personal message field

Expected Result:

The highlighted lines are not overlapping

Actual Result:

There is very little space between the lines

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / Chrome
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.42-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671484774271469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eeb6a2bced2c4533
• Upwork Job ID: 1606405025835712512
• Last Price Increase: 2022-12-23

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[NikkiWines]

Able to reproduce locally. Likely introduced by this change and this change since lineHeightNormal appears to be 16px on web, which is too small.

Looks like it impacts any multiline <TextInput> element.

[NikkiWines]

Looks like @Luke9389's PR should resolve the issue.

[Luke9389]

@NikkiWines I'll test this one out on my branch to be sure it fixes it. If not, I'll include the fix in my PR. Thanks for the heads up!

[Luke9389]

Ok cool, I can confirm that my branch form the linked PR above fixes this issue. 👍

[flaviadefaria]

As a note, I'm going to be OOO from Dec 23rd to January 9th. In case this needs to be paid before the week of January 9th then please reassign.

[flaviadefaria]

@Luke9389 @NikkiWines has this been fixed by Luke's PR? Can we close this?

[NikkiWines]

@flaviadefaria it looks like #12447 is still open, so no, I don't think it's been resolved yet. However, looks like they're in the final stages of review for that PR so it should be resolved shortly.

[Luke9389]

Yep, that PR should be merged soon. I've mentioned this issue in the description of my PR so I think this one will automatically close when it's merged.

[flaviadefaria]

Reopening so that I can remember to pay the reporting bonus to @daraksha-dk some time today!

[flaviadefaria]

Offer sent, waiting for @daraksha-dk to accept it so that I can pay.

[flaviadefaria]

Paid!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.60-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Text & Dropdown Input Styles #12447

If no regressions arise, payment will be issued on 2023-02-03. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@NikkiWines] The PR that introduced the bug has been identified. Link to the PR: Update baseTextInput line height to prevent cutoff #13389 and Remove clipped texts throughout the app when device font size is increased #10312
• [@NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Update baseTextInput line height to prevent cutoff #13389 (comment)
• [@NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - we've done a whole UI refresh since this bug was introduced. This bug was introduced in the midst of that and I think that was the major factor involved with having this regression slip through.
• [@flaviadefaria] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[flaviadefaria]

I'm confused with these latest post from Melvin. @NikkiWines do we just check it all off or do we need to do anything here?

[NikkiWines]

Updated the checklist since I went through the steps necessary for this issue. @flaviadefaria I think in this case since the bug was introduced in the midst of a major UI refresh that we don't need a regression test for this particular issue. I think you can check off that final check box.

[flaviadefaria]

Thanks @NikkiWines!