[HOLD for payment 2023-02-15] [$4000] Error message appears when sending 15000 emojis

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. navigate to any chat
2. send 15000 emoji to the chat
3. Compose with 15000 characters and add one more emoji

Expected Result:

Emojis should be sent since it's exactly 15000 and no error message should be.
Also after 15000 characters adding an emoji should show the count as 15001

Actual Result:

getting an error Auth CreeateReportAction returned an error
In step 3 shows the count as 15002

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.48-2

Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

view-count-bug.mov

Recording.1208.mp4

Recording.1207.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672427549244909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb872390d8ccc3cf
• Upwork Job ID: 1611228769941909504
• Last Price Increase: 2023-01-25

[adelekennedy]

@jayeshmangwani what platform are you getting this error on? This looks like a pretty reproducible bug and one we agreed we should solve

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb872390d8ccc3cf

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @stitesExpensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[adelekennedy]

asked clarifying question here before we make this external

[jayeshmangwani]

@jayeshmangwani what platform are you getting this error on?

@adelekennedy desktop

[adelekennedy]

Chrome? I'm trying to complete the checklist above

[jayeshmangwani]

Yes, gettings errors on macOS chrome and macOS desktop

[getusha]

this might be issue from the backend?

[adelekennedy]

@getusha yes! I asked a clarifying question here though I accidentally added 'external' too soon!

[mollfpr]

@adelekennedy I think we are looking for external approach?

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[stitesExpensify]

Thank you both for your clarification and honesty. In that case, @redstar504 will receive the full payout

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Count non-ASCII comment characters by their encoded length #14752

If no regressions arise, payment will be issued on 2023-02-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@redstar504] Propose regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[redstar504]

Regression Test Proposal

• Bug: Submitting 15,000 emojis results in an auth error
• Underlying cause: Emojis and other non-ASCII characters are not counted properly on the front-end
• Proposed Test Steps:
  • Go to URL https://staging.new.expensify.com/ and login with any account
  • Navigate to any conversation and focus on the compose box
  • Paste a comment containing 1,251 (or more) emojis — copy below
  • The send button should be disabled and should prevent you from sending the comment
  • The composer should display a red outline and the character counter should be displayed in red
  • Remove one emoji so you are left with 1,250 emojis, and submit using the send button
  • Your message should be sent successfully
  • Confirm on the participant's account that the message was received
  • Repeat the process for editing a comment
  • Ensure the enter key will not submit a new or edited comment when the character limit is exceeded

1251 Emojis:

😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄

• Additional Testing Steps:

  • Exceed the comment limit with any text
  • Confirm that the comment counter increases the character count by the corresponding amount:

  • Character	Counted As
    a	1
    8	1
    $	1
    ¢	6
    ©	6
    🤨	12
    👻	12
    😶‍🌫️	36
    👩‍👩‍👦‍👦	66

• Do we agree 👍 or 👎

[mollfpr]

@stitesExpensify I don't think there's any commit in E/App that cause this issue, probably some things that we haven't thought about on how BE handles the text sent from E/App.

@redstar504 Any thoughts on PR that causing this issue?

[redstar504]

@mollfpr It seems like more of a feature improvement than a bug. There wouldn't be a specific PR that caused it.

[mollfpr]

@stitesExpensify Do you have other thoughts? I believe we don’t need to add a new checklist because the regression test will catch the same issue.

[mollfpr]

Bump @stitesExpensify @adelekennedy

[stitesExpensify]

Sorry for the delay, I agree that we don't need to add a new checklist @mollfpr

[mollfpr]

@adelekennedy Should we issue the payment here? Thanks!

[adelekennedy]

Yes! Seems like we're g2g without the full checklist. Sending payment to @mollfpr and @redstar504 and @jayeshmangwani for reporting!

[adelekennedy]

@mollfpr @jayeshmangwani will you apply here?

[mollfpr]

@adelekennedy submitted!

[mollfpr]

@adelekennedy accepted the offer!

[adelekennedy]

Sent all payments!