-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD App Navigation Reboot] React navigation StackNavigator causes screen content to load slowly #14036
Comments
Triggered auto assignment to @jliexpensify ( |
📣 @chrispader! 📣 |
@marcaaron could you please add that issue here: #11768 |
Hi @marcaaron did you want a job created and @chrispader hired? |
No the issue is just on hold for now thanks @jliexpensify |
@jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@jliexpensify Eep! 4 days overdue now. Issues have feelings too... |
@marcaaron if this is on HOLD, could this be updated to a Weekly or Monthly? |
Yes 👍 |
Still on hold |
On hold |
Not overdue, on HOLD |
Not overdue, on HOLD |
Still on hold |
@chrispader I think this one can be closed now, please correct me if I am wrong. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
(long lasting LoadingIndicators on many screens)
Action Performed:
OptionsSelector
)Expected Result:
After the screen transition is done, the screen content should render relatively fast.
Actual Result:
Instead, even after the screen transition has ended a
LoadingIndicator
keeps spinning for a few (milli-)seconds.That's because the
OptionSelector
component is waiting for thetransitionEnd
event to be emitted byreact-navigation
. (here) The transition will end at earliest though, once the screen content is rendered completely.Workaround:
This is not blocking any flow.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.49-0
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers): christoph+hightraffic@margelo.io | iPhone 14 Pro (Simulator)
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @marcaaron & @chrispader
Slack conversation: https://expensify.slack.com/archives/C035J5C9FAP/p1669856870089949
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: