Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App Navigation Reboot] React navigation StackNavigator causes screen content to load slowly #14036

Closed
6 tasks done
chrispader opened this issue Jan 5, 2023 · 15 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@chrispader
Copy link
Contributor

chrispader commented Jan 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


(long lasting LoadingIndicators on many screens)

Action Performed:

  1. Open app
  2. Go to "Search"/"New Chat"/"New Group" screen (any Screen that renders an OptionsSelector)
  3. Wait for the loading spinner to end

Expected Result:

After the screen transition is done, the screen content should render relatively fast.

Actual Result:

Instead, even after the screen transition has ended a LoadingIndicator keeps spinning for a few (milli-)seconds.

That's because the OptionSelector component is waiting for the transitionEnd event to be emitted by react-navigation. (here) The transition will end at earliest though, once the screen content is rendered completely.

Workaround:

This is not blocking any flow.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.49-0
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers): christoph+hightraffic@margelo.io | iPhone 14 Pro (Simulator)
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @marcaaron & @chrispader
Slack conversation: https://expensify.slack.com/archives/C035J5C9FAP/p1669856870089949

View all open jobs on GitHub

@chrispader chrispader added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 5, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jan 5, 2023

📣 @chrispader! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

@melvin-bot melvin-bot bot closed this as completed Jan 5, 2023
@chrispader
Copy link
Contributor Author

chrispader commented Jan 5, 2023

@marcaaron could you please add that issue here: #11768

@marcaaron marcaaron reopened this Jan 5, 2023
@marcaaron marcaaron changed the title React navigation StackNavigator causes screen content to load slowly [HOLD App Navigation Reboot] React navigation StackNavigator causes screen content to load slowly Jan 5, 2023
@jliexpensify
Copy link
Contributor

Hi @marcaaron did you want a job created and @chrispader hired?

@marcaaron
Copy link
Contributor

No the issue is just on hold for now thanks @jliexpensify

@melvin-bot melvin-bot bot added the Overdue label Jan 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

@jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jan 11, 2023

@jliexpensify Eep! 4 days overdue now. Issues have feelings too...

@jliexpensify
Copy link
Contributor

@marcaaron if this is on HOLD, could this be updated to a Weekly or Monthly?

@melvin-bot melvin-bot bot removed the Overdue label Jan 11, 2023
@marcaaron
Copy link
Contributor

Yes 👍

@marcaaron marcaaron added Monthly KSv2 and removed Daily KSv2 labels Jan 13, 2023
@Expensify Expensify locked and limited conversation to collaborators Jan 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@jliexpensify
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Feb 23, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 27, 2023
@jliexpensify
Copy link
Contributor

On hold

@melvin-bot melvin-bot bot removed the Overdue label Mar 28, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@jliexpensify
Copy link
Contributor

Not overdue, on HOLD

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@jliexpensify
Copy link
Contributor

Not overdue, on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@jliexpensify
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 20, 2023
@mountiny
Copy link
Contributor

@chrispader I think this one can be closed now, please correct me if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants