Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] When pressing back from Step 2 (Connect Bank Manually), it navigate to Connect Bank Account page. #14973

Closed
1 task
kavimuru opened this issue Feb 8, 2023 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Feb 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open workspace => connect bank account manually, enter valid information for first 3 steps, close the page.
  2. Go to Workspace => connect bank account manually again => Continue with setup => Press back to go back to Step 2, press Back again.
  3. Notice that when you are at step 2 and press back, it navigate to Connect Bank Account page.

Expected Result:

It should navigate to step 1, when user press back at step 2.

##Actual Result:
When you are at step 2 and press back, it navigate to Connect Bank Account page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • MacOS / Chrome / Safari

Version Number: v1.2.67-6
Reproducible in staging?: Y
Reproducible in production?: Could not check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-08.at.15.16.02.mov
Recording.1472.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675844399748989
View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 8, 2023
@MelvinBot
Copy link

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 8, 2023
@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@miljakljajic
Copy link
Contributor

I'm not able to reproduce this: it takes me back to step 1, as expected:
image

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2023
@miljakljajic miljakljajic added the Needs Reproduction Reproducible steps needed label Feb 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2023
@MelvinBot
Copy link

@miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@miljakljajic
Copy link
Contributor

bumped on the slack thread

@miljakljajic
Copy link
Contributor

Holding for this: #11768

@miljakljajic miljakljajic changed the title When pressing back from Step 2 (Connect Bank Manually), it navigate to Connect Bank Account page. [HOLD] When pressing back from Step 2 (Connect Bank Manually), it navigate to Connect Bank Account page. Feb 17, 2023
@miljakljajic miljakljajic added Weekly KSv2 and removed Daily KSv2 labels Feb 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2023
@miljakljajic
Copy link
Contributor

Still holding!

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 8, 2023
@miljakljajic
Copy link
Contributor

Holding

@melvin-bot melvin-bot bot removed the Overdue label Mar 14, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 22, 2023
@miljakljajic
Copy link
Contributor

Holding

@melvin-bot melvin-bot bot removed the Overdue label Mar 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2023
@miljakljajic
Copy link
Contributor

Holding

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2023
@miljakljajic
Copy link
Contributor

Holding

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2023
@miljakljajic
Copy link
Contributor

Still holding!

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2023
@melvin-bot melvin-bot bot added the Overdue label May 3, 2023
@miljakljajic
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2023
@melvin-bot melvin-bot bot added the Overdue label May 12, 2023
@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@hungvu193
Copy link
Contributor

Seems this issue is fixed with navigation reboot, am I eligible for reporting bonus? @miljakljajic

@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants