[HOLD for payment 2023-05-02] [$4000] mweb/safari - Request money - viewport is jumping up and down when navigating menus

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Tap on FAB > Request Money > Navigate the currency & menus

Expected Result:

User expects that the viewport and buttons remain in a fixed position

Actual Result:

The buttons & viewport are jumping and moving around when opening and closing the keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.74.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5942090_Viewport___buttons_are_moving_when_navigating_the_menu.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015abb72f6bcd9af5a
• Upwork Job ID: 1630330487569076224
• Last Price Increase: 2023-03-13

[MelvinBot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • Potentially related: [HOLD for payment 2023-03-01] Black area generated above keyboard within company information form #14716
• This bug is reproducible using the reproduction steps in the OP. S/O
  • I was able to reproduce this using Browserstack on multiple iOS device versions.
• This issue is filled out as thoroughly and clearly as possible
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync - N/A

[strepanier03]

Was OoO yesterday for President's day, will handle today.

[strepanier03]

@puneetlath - Would you mind taking a look at this GH and letting me know if your GH here is related? After reading through your GH and the solution and behaviors for iOS m/web described here seem similar.

I'm torn between adding external because it's easily reproducible behavior and waiting to see if the PR for your GH fixes this or alters the behavior.

[puneetlath]

Hm, it could be yeah. Maybe let's put this on hold until that PR hits staging and then we can see if it solved the problem or not.

[strepanier03]

Thank you @puneetlath I will do that and follow along with the PR progress.

[strepanier03]

Retesting since the other PR is in prod now.

[strepanier03]

All right, this is still occurring so sending on and removing hold status.

[strepanier03]

Testing:

Able to recreate with the testing steps in the OG comment.

2023-02-27_14-06-37.mp4

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015abb72f6bcd9af5a

[MelvinBot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Triggered auto assignment to @hayata-suenaga (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[PankajAS]

Proposal

Please re-state the problem that we are trying to solve in this issue.

View of Amount page height shrink and grow when navigate from currency selection

What is the root cause of that problem?

Root cause of that problem is flex:1 which is filling available space in IOS/safari after navigate because parent view don't have minHeight.

What changes do you think we should make in order to solve the problem?

We have to add minHeight for IOUAmountPage component's parent view.

Untitled.1.mp4

What alternative solutions did you explore? (Optional)

None

[strepanier03]

@gedu @hayata-suenaga @cubuspl42 - Any update here or next steps we can take to move things forward?

[hayata-suenaga]

@gedu's PR is almost ready. @gedu could you check again @cubuspl42's comments that the change he is suggesting and your PR doesn't conflict?

[gedu]

@hayata-suenaga is all fixed

[strepanier03]

@gedu - How are we looking on this one? Any update that can be provided?

[gedu]

@strepanier03 Merged

[strepanier03]

Splendid, thank you @gedu!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.4-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Viewport jumping up #16443

If no regressions arise, payment will be issued on 2023-05-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@strepanier03] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@dylanexpensify is going to take over this GH for me since it will need action before I return from OoO and I don't want this to be held up on my return.

Thank you Dylan 🙌

[dylanexpensify]

Missed this! Let's pay some people!

[dylanexpensify]

@thesahindia mind giving me an overview of this one and tackling the checklist items?

[dylanexpensify]

@thesahindia @gedu please apply for the job here! 🙇

[thesahindia]

Applied, thanks!

[TomaszFrackowiak]

@dylanexpensify - hey, gedu is from Callstack :-)

[melvin-bot]

📣 @TomaszFrackowiak! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dylanexpensify]

@thesahindia sent offer!

[thesahindia]

Accepted!

[dylanexpensify]

@thesahindia payment sent, contract ended
RT here

[dylanexpensify]

@thesahindia can you please complete the checklist items assigned to you? 🙇‍♂️