Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-15] [Navigation Reboot] Update the react-navigation version #15846

Closed
mountiny opened this issue Mar 10, 2023 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 10, 2023

Tracking issue #11768

Created a new branch navigation-refactor to which we will merge all the PRs of this refactor.

Lets start with updating the react-navigation version we use in the App to latest version.

Bookmark in the doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01812a3f50c7ff3a9b
  • Upwork Job ID: 1634918457811042304
  • Last Price Increase: 2023-03-12
@mountiny mountiny added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Mar 10, 2023
@mountiny mountiny self-assigned this Mar 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@mountiny mountiny changed the title [Navigation Reboot] Update the react-navigation version https://docs.google.com/document/d/1cQ87HcDA9RrmBM4ch7PmlNi9N9ZP8abQuPF0gKYrxDE/edit#bookmark=id.98pya0o6114h [Navigation Reboot] Update the react-navigation version Mar 10, 2023
@Expensify Expensify unlocked this conversation Mar 10, 2023
@adamgrzybowski
Copy link
Contributor

Going to implement this

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Mar 12, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01812a3f50c7ff3a9b

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@mountiny
Copy link
Contributor Author

Not overdue, gonna be implementing this week.

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 13, 2023
@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 16, 2023
@MelvinBot
Copy link

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mountiny mountiny removed the Bug Something is broken. Auto assigns a BugZero manager. label Mar 16, 2023
@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor Author

@johncschuster Could you please help payout @s77rt $1000 for reviewing and testing the PR? Thank you!

@MelvinBot
Copy link

@johncschuster, @s77rt, @mountiny, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor Author

This is completed

@s77rt
Copy link
Contributor

s77rt commented Mar 29, 2023

@mountiny Can we reopen this? I think payment has not been handled here (unless I missed it 😅) @johncschuster Can you confirm the same?

@johncschuster
Copy link
Contributor

Sorry I missed your ping, @mountiny! I'll get the payment issued right now!

@johncschuster
Copy link
Contributor

@s77rt, can you apply to the job and ping me when you're done? I'll make quick work of this for ya.

https://www.upwork.com/jobs/~01812a3f50c7ff3a9b

@s77rt
Copy link
Contributor

s77rt commented Mar 29, 2023

@johncschuster Applied

@mountiny
Copy link
Contributor Author

Oops sorry, seems like its being handled

@mountiny mountiny reopened this Mar 29, 2023
@johncschuster
Copy link
Contributor

Paid! Thanks for your patience @s77rt!

@s77rt
Copy link
Contributor

s77rt commented Mar 29, 2023

Thanks! @johncschuster Let's end the contract as well.

@roryabraham roryabraham removed the Reviewing Has a PR in review label Apr 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2023
@mountiny
Copy link
Contributor Author

I think this is all sorted, right? @s77rt

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2023
@s77rt
Copy link
Contributor

s77rt commented Apr 12, 2023

@mountiny Almost, I think the contract is still ongoing in Upwork. Should it be terminated from your side? cc @johncschuster

@mountiny
Copy link
Contributor Author

Was this paid though?

@s77rt
Copy link
Contributor

s77rt commented Apr 12, 2023

Yeah, sorry if that was unclear

@laurenreidexpensify laurenreidexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 13, 2023
@MelvinBot
Copy link

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@laurenreidexpensify
Copy link
Contributor

John is OOO, reassigning so this gets actioned. thanks!

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@trjExpensify
Copy link
Contributor

Removing the bug label again though as this a new feature.

@trjExpensify trjExpensify removed the Bug Something is broken. Auto assigns a BugZero manager. label Apr 13, 2023
@mountiny
Copy link
Contributor Author

Wow navigating Upwork should be a Masters degree course at university. All set, closing

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title [Navigation Reboot] Update the react-navigation version [HOLD for payment 2023-06-15] [Navigation Reboot] Update the react-navigation version Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants