Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation Reboot] Implement and use the createStackNavigator #15847

Closed
mountiny opened this issue Mar 10, 2023 · 15 comments
Closed

[Navigation Reboot] Implement and use the createStackNavigator #15847

mountiny opened this issue Mar 10, 2023 · 15 comments
Assignees
@mountiny @adamgrzybowski
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 10, 2023 •
edited by melvin-bot bot

Tracking issue #11768

Created a new branch navigation-refactor to which we will merge all the PRs of this refactor.

Implement and use the createStackNavigator.

Bookmark in the doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014c76ad7f6d5103fa
  • Upwork Job ID: 1634919831371452416
  • Last Price Increase: 2023-03-12
@mountiny mountiny added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Mar 10, 2023
@mountiny mountiny self-assigned this Mar 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@Expensify Expensify unlocked this conversation Mar 10, 2023
@mountiny mountiny mentioned this issue Mar 10, 2023
Closed
7 tasks
@adamgrzybowski
Copy link
Contributor

Going to implement this

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Mar 12, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~014c76ad7f6d5103fa

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2023
@mountiny
Copy link
Contributor Author

Not overdue, gonna be implementing this week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 13, 2023
@mountiny
Copy link
Contributor Author

@adamgrzybowski can you please leave a comment daily on each of the daily issues with an update (so they dont go overdue)

@melvin-bot melvin-bot bot removed the Overdue label Mar 16, 2023
@adamgrzybowski
Copy link
Contributor

@mountiny Is the daily tag necessary?

@mountiny
Copy link
Contributor Author

mountiny commented Mar 16, 2023 •
edited

I feel like for those three yeah, you can always just comment: "no update, worked on this(link) today"

Or do you think some other should be daily instead?

@melvin-bot melvin-bot bot added the Overdue label Mar 20, 2023
@mountiny
Copy link
Contributor Author

Work will resume now once ECX is done

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2023
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Mar 21, 2023
@mountiny
Copy link
Contributor Author

Unassigning CPlus for now, I will ask in the channel once the PR will be ready

@melvin-bot melvin-bot bot added the Overdue label Mar 30, 2023
@mountiny
Copy link
Contributor Author

Working on other PRs from the project so far, this will come next

@melvin-bot melvin-bot bot removed the Overdue label Mar 30, 2023
@arosiclair arosiclair mentioned this issue Apr 7, 2023
Merged
53 tasks
@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@mountiny
Copy link
Contributor Author

Back from Easter, work continues

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2023
@mountiny
Copy link
Contributor Author

the main pr will be merged soon so this will be worked on shortly

@mountiny mountiny added Daily KSv2 and removed Weekly KSv2 labels Apr 24, 2023
@mountiny
Copy link
Contributor Author

Making this Daily as we are unblocked after removing the drawer navigation

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@mountiny
Copy link
Contributor Author

We decided not to implement different stack navigator, closing this one

@mountiny mountiny closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountiny mountiny

@adamgrzybowski adamgrzybowski

Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eVoloshchak @MelvinBot @mountiny @adamgrzybowski