[HOLD for payment 2023-06-15] [HOLD for payment 2023-05-26] [Navigation Reboot] Remove the X from modal screens

[mountiny]

Tracking issue #11768

Created a new branch navigation-refactor to which we will merge all the PRs of this refactor.

Remove X from the modal screens

Bookmark in the doc

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01453b9cb7d461b061
• Upwork Job ID: 1634918756517261312
• Last Price Increase: 2023-03-12

[adamgrzybowski]

Going to implement this

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01453b9cb7d461b061

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[adamgrzybowski]

Work will resume now once ECX is done

[mountiny]

Unassigning CPlus for now, I will ask in the channel once the PR will be ready

[mountiny]

Working on other PRs from the project so far, this will come next

[mountiny]

Back from Easter, work continues

[mountiny]

the main pr will be merged soon so this will be worked on shortly

[mountiny]

this one should be simple, lets knock it out of the way fast ⚡

[mountiny]

PR done, flat review rate for @0xmiroslav at $1000 once the payment is due, thank you!

[mountiny]

@anmurali once you are around there is just payment to be handled here and we can close this issue, thanks!

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Actually I think Anu is still ooo so reassigning

[0xmiroslav]

Thanks @mountiny

[michaelhaxhiu]

hired @0xmiroslav here - https://www.upwork.com/jobs/~01327e1b6e9a42d905

waiting for him to accept because the OG job link expired

[michaelhaxhiu]

paid.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Navigation Reboot] Implement UP press #18402

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty