Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-23] [Navigation Reboot] Add NAVIGATION.md file to the repository #15854

Closed
mountiny opened this issue Mar 10, 2023 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Tracking issue #11768

Once we are done with the implementation, we will add a new markdown file with important information handy to the contributors and any engineer who wants to understand how the navigation of the app works.

https://docs.google.com/document/d/1cQ87HcDA9RrmBM4ch7PmlNi9N9ZP8abQuPF0gKYrxDE/edit#bookmark=id.so7tbafaepdw

@mountiny mountiny added Monthly KSv2 NewFeature Something to build that is a new item. Task labels Mar 10, 2023
@mountiny mountiny self-assigned this Mar 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@Expensify Expensify unlocked this conversation Mar 10, 2023
@adamgrzybowski
Copy link
Contributor

Creating the placeholder

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

@mountiny, @adamgrzybowski, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed May 29, 2023
@mountiny mountiny changed the title [HOLD] [Navigation Reboot] Add NAVIGATION.md file to the repository [Navigation Reboot] Add NAVIGATION.md file to the repository May 30, 2023
@mountiny mountiny removed Reviewing Has a PR in review Not a priority labels May 30, 2023
@mountiny mountiny reopened this May 30, 2023
@mountiny
Copy link
Contributor Author

We still need to add the documentation

@mountiny mountiny added the Reviewing Has a PR in review label May 31, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jun 16, 2023
@melvin-bot melvin-bot bot changed the title [Navigation Reboot] Add NAVIGATION.md file to the repository [HOLD for payment 2023-06-23] [Navigation Reboot] Add NAVIGATION.md file to the repository Jun 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@mountiny
Copy link
Contributor Author

No payment required here, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants