Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Auto focus is broken on New room page #17479

Closed
1 of 6 tasks
kavimuru opened this issue Apr 16, 2023 · 70 comments
Closed
1 of 6 tasks

[$1000] Auto focus is broken on New room page #17479

kavimuru opened this issue Apr 16, 2023 · 70 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Apr 16, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login with any account
  2. Tap or click FAB menu > New room

Expected Result:

Auto focus on room name input and keyboard shows

Actual Result:

Room name input is not focused and "Create room" button bounces

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3..0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

FHQB4145.1.MP4
new.room.bug.mp4

Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681493406622809

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0160117b7c7096e58e
  • Upwork Job ID: 1651569523514560512
  • Last Price Increase: 2023-08-21
  • Automatic offers:
    • situchan | Contributor | 26258358
    • situchan | Reporter | 26258360
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 16, 2023
@MelvinBot
Copy link

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2023
@MelvinBot
Copy link

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

I'm not sure how to "tab" the FAB menu on mobile. I've asked for clarity on the repro steps in the Slack thread above.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 20, 2023
@MelvinBot
Copy link

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster
Copy link
Contributor

I've reproduced the behavior. Triaging!

@MelvinBot
Copy link

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johncschuster
Copy link
Contributor

Umm... this isn't overdue, Melv.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 25, 2023
@techievivek
Copy link
Contributor

This can be worked externally.

@melvin-bot melvin-bot bot removed the Overdue label Apr 27, 2023
@techievivek techievivek added the External Added to denote the issue can be worked on by a contributor label Apr 27, 2023
@melvin-bot melvin-bot bot changed the title Auto focus is broken on New room page [$1000] Auto focus is broken on New room page Apr 27, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0160117b7c7096e58e

@MelvinBot
Copy link

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2023
@techievivek
Copy link
Contributor

Awesome, can't we test this on staging to confirm if it fixes this bug or not?

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2023
@situchan
Copy link
Contributor

Awesome, can't we test this on staging to confirm if it fixes this bug or not?

Ah yes we can test on staging but only internally. External contributors don't have access to staging iOS build

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

@johncschuster, @techievivek, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster
Copy link
Contributor

@techievivek I'm a bit confused on where we stand on this one. Do we need to test this internally?

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2023
@situchan
Copy link
Contributor

This was deployed to production. Not reproducible anymore.

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

@johncschuster, @techievivek, @situchan Eep! 4 days overdue now. Issues have feelings too...

@johncschuster
Copy link
Contributor

Thanks, @situchan! In that case, can we close this one out?

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@situchan
Copy link
Contributor

situchan commented Sep 5, 2023

Thanks, @situchan! In that case, can we close this one out?

yes, and I think I am eligible for reporting bonus

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@johncschuster, @techievivek, @situchan Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@johncschuster, @techievivek, @situchan Eep! 4 days overdue now. Issues have feelings too...

@techievivek
Copy link
Contributor

Not overdue, we just need to issue the reporting bonus here.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 11, 2023
@techievivek
Copy link
Contributor

@johncschuster Can we issue the reporting bonus to @situchan and close this issue? Thanks

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@johncschuster, @techievivek, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster
Copy link
Contributor

Sorry I missed this! Yep! I'll get the reporting bonus issued.

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2023
@situchan
Copy link
Contributor

@johncschuster I already have accepted contract from $250 offer. Thanks

@techievivek
Copy link
Contributor

@johncschuster Have we finished the payment here? Can I close the issue?

@johncschuster
Copy link
Contributor

Yep! Payment has been issued! We're good to close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests