[$1000] Invalid email prefixes aren’t treated as invalid in contact methods page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot
2. Go to profile-> contact method-> new contact
3. On email/phone number field enter the following mailing addresses
4. abc-@mail.com
5. abc#def@mail.com
   Note :
   According to RFC 5322, which defines the standard for email addresses, the local-part (the part before the '@' symbol) can only contain certain characters, including alphanumeric characters, dots, and a limited set of special characters, such as underscores and hyphens. The pound sign (#) is not one of the allowed special characters.
   Also, The local-part cannot start or end with a hyphen, so the email address "abc-@mail.com" is considered invalid.

Expected Result:

error handling with improper email address

Actual Result:

Some cases are not checked properly..

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2023-04-22-10-02-37.mp4

Recording.316.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682146812820119
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015a1956a9c964cbc5
• Upwork Job ID: 1650863060849467392
• Last Price Increase: 2023-04-25

[MelvinBot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015a1956a9c964cbc5

[MelvinBot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[abekkala]

I was able to recreate using an incorrect hyphen placement

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MelvinBot]

Triggered auto assignment to @francoisl (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[aimane-chnaif]

I suggest to put this on hold for #17387 which has possibility to unify all email validations.

[jaymangukiya0001]

Proposal

Please re-state the problem that we are trying to solve in this issue.
the invalid special character is allowed as a prefix in the email.

What is the root cause of that problem?

in the src/pages/settings/profile/contacts/newContactMethodPage.js line, no 82 is having inbuilt validation method which looks inappropriate in some cases for the special character at the prefix.

What changes do you think we should make in order to solve the problem?

we can use regex ^([a-z0-9\+\.\/&!][-a-z0-9\+\._\/&!]*[A-Za-z0-9])@(([a-z0-9][-a-z0-9]*\.)([-a-z0-9]+\.)*[a-z]{2,})$ to match email string which passes all the test cases as per the email format you mentioned in this issue.

What alternative solutions did you explore? (Optional)

I have explored the third-party packages but it can be inappropriate for some cases.

[parasharrajat]

@abekkala I think we can close this as it seems a duplicate of #17387

[abekkala]

Ah good call. I didn't see that one when I looked. Must have used a bad search term. That one was created well before this one so closing.

Thanks @parasharrajat

[jaymangukiya0001]

@parasharrajat @abekkala @MelvinBot i don't think so that regex mentioned in !17387 will include all the test cases for identifying the email totally valid. Here is the proof.

I think my regex is more appropriate (passing all the test cases that you have mentioned in the issue except the length but i can add that check as well. )