Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-15] [Navigation Refactor] Pronouns page has no animation when opening #18092

Closed
mountiny opened this issue Apr 27, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Problem

The pronouns page in settings has no animation when opening which is inconsistent with other pages (tested on web)

Screen.Recording.2023-04-27.at.11.35.31.mov

Solution

Ensure all he pages in RHP have the same animation when closing nad opening.

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 27, 2023
@mountiny mountiny self-assigned this Apr 27, 2023
@MelvinBot
Copy link

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 27, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Apr 27, 2023

No need to act here @kadiealexander its a part of a new feature refactor. We will see if there will be anyone to pay at the end

SWM will take care of this

@kadiealexander
Copy link
Contributor

Roger that, thanks Vit!

@mountiny
Copy link
Contributor Author

@staszekscp can you comment on this issue so I can assign you? thanks!

@staszekscp
Copy link
Contributor

Sure, thanks!

@mountiny
Copy link
Contributor Author

mountiny commented May 2, 2023

thanks!

@melvin-bot melvin-bot bot added the Overdue label May 10, 2023
@mountiny
Copy link
Contributor Author

@staszekscp not overdue just need to test it with the UP implementation

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@staszekscp
Copy link
Contributor

Hey, the fix has been included into this PR!

@mountiny
Copy link
Contributor Author

Ok lets always link it in the PR withth $ https://github.com/Expensify/App/issues/18092

@mountiny mountiny added the Reviewing Has a PR in review label May 15, 2023
@mountiny
Copy link
Contributor Author

PR done, nothing to pay here

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title [Navigation Refactor] Pronouns page has no animation when opening [HOLD for payment 2023-06-15] [Navigation Refactor] Pronouns page has no animation when opening Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants