[HOLD for payment 2024-03-20] [$500] Users can enter more characters than the specified limit

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the Settings > Profile >Display name
2. Enter a name exceeding the character limit and continue typing on first name field

Expected Result:

Users should not enter more than the specified limit of characters

Actual Result:

Users can enter more characters than the specified limit in the First name and Last name fields and removed extra characters after pressing space button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20230513010402.mp4

az_recorder_20230513_123426.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683923406716779

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a433a674a93990d0
• Upwork Job ID: 1760227161153392640
• Last Price Increase: 2024-02-21
• Automatic offers:
• aimane-chnaif | Reviewer | 0
• dhairyasenjaliya | Contributor | 0

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

this can be hold in favour of #18647 still we need to decide limit

[laurenreidexpensify]

Making this a weekly

[laurenreidexpensify]

No update on #18647 so still on hold

[laurenreidexpensify]

No update on #18647 so remains on hold again this week

[laurenreidexpensify]

No update on #18647 so remains on hold again this week, Joe was OOO last week

[laurenreidexpensify]

@joekaufmanexpensify can you watch this one for me while I'm OOO, as the hold is from your issue in #18647 thanks! back 19 June

[joekaufmanexpensify]

Sure!

[joekaufmanexpensify]

Started a discussion on a standardized limit framework in slack!

[joekaufmanexpensify]

Slack discussion on standardized limit framework is still ongoing. Next step is I'm going to research why we decided on some of the existing limits in the app now.

[laurenreidexpensify]

Thanks Joe! I'm back so will keep up the pace on this one

[laurenreidexpensify]

Still held on #18647

[laurenreidexpensify]

@aimane-chnaif can you confirm if we need a checklist here?

[aimane-chnaif]

Oops payment is too early.
@laurenreidexpensify App PR is not merged yet. I think you confused with backend PR

As you release payment already, I suggest not refund assuming no regressions.
We can just close this 7 days after PR reaches production.

@aimane-chnaif can you confirm if we need a checklist here?

There's no regression but I think we should add new regression test for this.

Regression Test Proposal

1. Go to the Settings > Profile > Display name
2. Enter a name exceeding the character limit (100) and continue typing on the first name or last name field
3. Verify that user is still able to type characters
4. Click Save
5. Verify that exceed error shows on both fields

[ayazhussain79]

@laurenreidexpensify @aimane-chnaif Am i eligible for reporting bonus, this bug was reported May 13, 2023?

[laurenreidexpensify]

Thanks for the catch @aimane-chnaif!

[laurenreidexpensify]

@ayazhussain79 sorry the bug reporting programme ended in Sept 2023, we no longer compensate for bug reports. Thanks

[ayazhussain79]

@laurenreidexpensify The bug, reported before September 2023 and held for various reasons, is now going to be fixed.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add character limit on display name #37125

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @dhairyasenjaliya requires payment automatic offer (Contributor)
• @aimane-chnaif requires payment automatic offer (Reviewer)
• @ayazhussain79 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

@ayazhussain79 let's handle your payment in #38941

@aimane-chnaif pls complete checklist above thanks

[aimane-chnaif]

This is more like feature request.

Regression Test Proposal

1. Go to Settings > Profile > Display name
2. Enter more then 100 characters on first / last name fields
3. Verify that characters can be entered endlessly
4. Click on Save button
5. Verify that character limit exceeded error shows

[luacmartins]

I don't think that we need to add this case. It's a bit extreme that people would enter more than 100 chars into a name field, so I don't think we need to be explicitly testing this.

[aimane-chnaif]

Thanks, we can just close this then after all payment set.