[Polish] Make the RHP animations always working on web and they are smooth

[mountiny]

Clean up for the #11768

Problem

Because of using stack navigation for all the pages in the App, when we close a modal we lose the information about the route and what should be rendered so its not easy to animate closing the modal. We are showing or closing the RHP modal abruptly because of that.

Additionally if you navigate to a deeplink RHP like settings/security, we use replace to go up in the stack but those pages are not in the stack yet so animating to them is trickier.

Additionally, thr animations are not smooth at all time which you can see on an attached video here

Screen.Recording.2023-06-07.at.09.46.36.mov

Why is it important

Animations give a better feel to the app and its important to keep the animations consistent

Solution

Lets ensure:

• we can have the same animation to the RHP modal for any open and close action
• the animations are performant and smooth

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[WoLewicki]

Commenting

[mountiny]

Focusing on bugs now

[mountiny]

@WoLewicki @adamgrzybowski will you or anyone from SWM be able to pick this up as with animations its best to utilize you?

[adamgrzybowski]

I still have some other tasks on my plate. But I could look at this later, or sooner if the priority is high.

[kosmydel]

Hi, I will have a try on this task. I'm an external from SWM.
For now, I will focus on animating the entry and exit of RHP, not the smoothness of the animations.

[adamgrzybowski]

Hey, let's wait with this issue as changes related to resizing and remounting would change the implementation. cc: @mountiny @kosmydel

[mountiny]

Exciting!

[mountiny]

This is being worked on in the styling PR

[mountiny]

On hold for the styling issue still

[melvin-bot]

This issue has not been updated in over 15 days. @WoLewicki, @mountiny, @MitchExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

There is a PR actively being worked on

[melvin-bot]

@WoLewicki, @mountiny, @MitchExpensify, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[mountiny]

I think this was actually solved in most cases