[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] [$500] Contact methods - Fix the errors CTA in Add new contact method page crashes the app

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.92.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #29869

Note: Crash is reproducible on Android and iOS app.
On web and desktop, console error shows up.

Action Performed:

1. Launch New Expensify app.
2. Go to Settings > Profile > Contact methods.
3. Click New contact method.
4. Enter an invalid email.
5. Click Save.
6. Click Fix the errors.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6253053_1698397438060.Screen_Recording_20231027_102606_One_UI_Home.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131fa74ee0414e807
• Upwork Job ID: 1717976360459390976
• Last Price Increase: 2023-10-27

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Problem

Issue: The "Add new contact" (CTA) in the "Add new contact method" page is causing the app to crash.

Root Cause

The root cause of the issue is related to the registerInput function used in the InputWrapper component. It appears that registerInput is designed to accept a ref object, not a function. When the onFixTheErrorsLinkPressed function is triggered here, the focusInput becomes undefined because it's accessed as inputRefs.current[focusKey].current and inputRefs.current[focusKey] is a function and while focusInput.isFocusedis accessed here app crashes.

Changes

There are two possible solutions to address this issue:

Temporary Solution

A temporary solution would be to pass the ref like this in the NewContactMethodPage.js file:

ref={loginInputRef}

Instead of:

ref={(el) => (loginInputRef.current = el)}

This temporary solution can be applied quickly to prevent the app from crashing.

Alternative Solution

An alternative solution would involve modifying the registerInput function to support function-based refs. This modification can be implemented in the FormProvider. Here's the proposed change in the FormProvider:

ref: typeof newRef === 'function' ? (node) => {
    newRef(node);
    const inputRef = createRef();
    inputRef.current = node;
    inputRefs.current[inputID] = inputRef;
} : newRef,

With these changes, the registerInput function would be able to handle both ref objects and function-based refs, and the issue causing the app to crash should be resolved.

Please note that the alternative solution might require more changes but could be a more robust and long-term fix for this issue.

[marcaaron]

cc @luacmartins

I think we should accept both object or function (alternative solution).

[luacmartins]

Agreed that it should accept both.

[luacmartins]

@ishpaul777 are you available to work on the alternate solution fix in the next few minutes?

[ishpaul777]

yes i am available

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

It's yours! Please tag me for review

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131fa74ee0414e807

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[luacmartins]

Fix is being CPed. Keeping this issue open to process payment.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Fix: crash on click of Error message CTA #30536

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment
• @ishpaul777 requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

I didn't review the PR actually. It was reviewed internally.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Fix: crash on click of Error message CTA #30536

If no regressions arise, payment will be issued on 2023-11-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment
• @ishpaul777 requires payment

[luacmartins]

Just pending payment

[maddylewis]

Payments

• Reporter: N/A
• Contributor: @ishpaul777 ($500 paid via Upwork)
• C+: @abdulrahuman5196 ($500 paid via Upwork)

@luacmartins - does that look right to you? i couldn't see when the contributor was hired / if anyone is eligible for urgency bonus.

[maddylewis]

offers sent ($500 via Upwork)

[maddylewis]

paid