Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Bottom Tab Navigator #32941

Closed
hayata-suenaga opened this issue Dec 12, 2023 · 28 comments
Closed

Implement Bottom Tab Navigator #32941

hayata-suenaga opened this issue Dec 12, 2023 · 28 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

As part of the Ideal Nav overhaul, implement the Bottom Tab Navigator according to the requirements specified in the design doc.

Parent Issue: #32689

@hayata-suenaga hayata-suenaga added Weekly KSv2 NewFeature Something to build that is a new item. labels Dec 12, 2023
Copy link

melvin-bot bot commented Dec 12, 2023

@hayata-suenaga
Copy link
Contributor Author

@adamgrzybowski from Software Mansion is going to work on this issue 🎉

@adamgrzybowski
Copy link
Contributor

👋

@joekaufmanexpensify
Copy link
Contributor

Going to unassign myself for now, since this we already have someone assigned for this, and it's a new feature rather than a bug. If any BZ work (like issuing payment) is required at any point, please re-assign me, and I'll handle it!

@joekaufmanexpensify joekaufmanexpensify removed their assignment Dec 12, 2023
@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

@adamgrzybowski Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Dec 19, 2023
@hayata-suenaga
Copy link
Contributor Author

I remember @adamgrzybowski is taking OOO. I'll change the priority of this issue to weekly until he's back.

Copy link

melvin-bot bot commented Dec 21, 2023

@adamgrzybowski Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Dec 25, 2023

@adamgrzybowski 10 days overdue. I'm getting more depressed than Marvin.

Copy link

melvin-bot bot commented Dec 27, 2023

@adamgrzybowski 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 1, 2024
Copy link

melvin-bot bot commented Jan 1, 2024

This issue has not been updated in over 14 days. @adamgrzybowski eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jan 1, 2024
@trjExpensify
Copy link
Contributor

Critical priority, putting this back on Daily now we're all back.

@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Jan 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 3, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

@adamgrzybowski Eep! 4 days overdue now. Issues have feelings too...

@hayata-suenaga
Copy link
Contributor Author

@adamgrzybowski let me know if you're working on this one in the internal branch of Software Mansion's

@flaviadefaria
Copy link
Contributor

This implementation is also important for Travel V1 so excited to see that this is a critical priority again!

Copy link

melvin-bot bot commented Jan 10, 2024

@adamgrzybowski 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@hayata-suenaga
Copy link
Contributor Author

The work is being down in this PR.

Vit made an ad hoc build out of that branch. You can access the build at this URL: https://33280.pr-testing.expensify.com/

Copy link

melvin-bot bot commented Jan 12, 2024

@adamgrzybowski 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed Daily KSv2 labels Jan 12, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 12, 2024
@hayata-suenaga
Copy link
Contributor Author

I'll change the priority of this issue to weekly as the PR is actively being worked on.

we just need this issue to figure out when the work is done

@luacmartins
Copy link
Contributor

assigning myself to help review and get this merged asap since it's a blocker for simplified collect

@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2024
@luacmartins luacmartins self-assigned this Jan 31, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Jan 31, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 2, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 3, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@s77rt
Copy link
Contributor

s77rt commented Feb 7, 2024

Can someone assign me here?

@luacmartins
Copy link
Contributor

Done!

@hayata-suenaga
Copy link
Contributor Author

@s77rt were you assigned here for the big feature branch you reviewed? I feel like I assigned you somewhere else 🤔

@hayata-suenaga
Copy link
Contributor Author

@s77rt you were assigned to this issue

@s77rt
Copy link
Contributor

s77rt commented Feb 8, 2024

@hayata-suenaga Maybe deja-vu? 😅 Yeah I'm assigned there too. That's the main issue. This one is only part of it. I thought it makes sense to be assigned on both.

@hayata-suenaga
Copy link
Contributor Author

I made you're paid more than the standard amount for the PR you reviewed in the other issue.

I'll keep you assigned to this issue, but payment is not needed here

also, closing this issue as the PR has been deployed to production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

8 participants