Modify the UpdateMoneyRequestDistance API endpoint

[blimpich]

Problem

We need the UpdateMoneyRequestDistance endpoint to give the frontend more information in its response in order to complete #34686.

Solution

Three things need to happen:

1. We need the endpoint to calculate the difference between existing and new waypoints
2. We need it to explicitly return waypoints that have been removed as null
3. All non-null waypoints should be moved to the start of the response

i.e.

{
  w0: A
  w1: B (remove)
  w2: C
  w3: D (remove)
}

Should turn into:

{
  w0: A
  w1: C
  w2: null
  w3: null
}

Please see this comment/discussion for more details.

cc: @paultsimura @tgolen

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d6425ace3c091bfc
• Upwork Job ID: 1752762514809204736
• Last Price Increase: 2024-01-31

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d6425ace3c091bfc

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[isabelastisser]

Waiting for proposals.

[isabelastisser]

Still waiting for proposals.

[aimane-chnaif]

This is marked as Internal.
@blimpich is this being done internally or open for contributors?

[blimpich]

Yup internal. Need an expensify engineer to do this. Not waiting on proposals.

[melvin-bot]

@isabelastisser, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tgolen]

I'm going to grab this one and start on it.

[tgolen]

@blimpich I was able to create a PR that covers this case and formats the results as expected. I have also made it handle this situation:

The request is created with these waypoints:

{
  w0: A
  w1: B
  w2: C
  w3: D
  w4: E
}

The request is updated to remove B and D and adds an F. This is the resulting Onyx update.

{
  w0: A
  w1: C
  w2: E
  w3: F
  w4: null
}

I hope that's expected.

[tgolen]

Daily Update

• The Web-E PR was created and is in review

[tgolen]

Daily Update

• The Web-E PR has had two reviews and is nearly ready to merge.

[melvin-bot]

@tgolen @isabelastisser @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[tgolen]

Daily Update

• The Web-E PR has been merged and it is on staging.

[tgolen]

Daily Update

• The Web-E PR has been deployed to production.