-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-14] [$500][P2P Distance] Create UpdateMoneyRequestDistanceRate in App #36987
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01fde353d38f5fdf1b |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Triggered auto assignment to @stephanieelliott ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Once the What is the root cause of that problem?This is a new feature request What changes do you think we should make in order to solve the problem?This should be done after the Rate field is added to the Money Requests. First, we should add the We need to add the function that will call the BE What alternative solutions did you explore? (Optional) |
Commenting to help with the review. |
@paultsimura's proposal looks good. Sounds like we will hold on #36985, so updating the title for that. |
📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Just a side note: I'm currently waiting for a new fix of #36969 |
Hey @paultsimura does that mean we should put this issue on hold for #36969? Or were you waiting on just one of the linked PRs there (there are a few) |
Yes, we need to put this on hold for #36969. But I think it'll be deployed quite soon. |
Sounds good -- I'll keep an eye on the issue and wait a bit before marking this GH as HOLD |
Hey @paultsimura looks like #36969 was merged to prod, so we should be unblocked here now! |
Hi, thanks, I'm working on this 👍 |
Today's update: I've almost finished the PR. Only final testing remains. |
The PR is ready: #40021 |
PR is awaiting your review @mananjadhav |
Thanks for the bump @stephanieelliott. I'll finish this today. |
PR was merged to Main earlier today! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@stephanieelliott will you please handle payment and then we can close this out? |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-14. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Create UpdateMoneyRequestRate following this plan. Please be sure to read and understand the relevant sections of the entire plan as well.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @stephanieelliottThe text was updated successfully, but these errors were encountered: