-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MEDIUM] Create new Trip Room #37825
Comments
Hey! I’m Wojtek from Software Mansion, the expert agency, and I’d like to work on this issue. |
Adding a C+ here for Travel reviews: @shubham1206agra |
Only assigned on Friday. We can give them a day here Melvin. |
@twisterdotcom, @WojtekBoman, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Are we waiting on anything internal here? |
Hi! I'm Aleksandra from Software Mansion, the expert agency, and I would like to take it over from Wojtek and work on this issue. |
@smelaa only assigned on Friday. |
@twisterdotcom @shawnborton @dannymcclain @stitesExpensify
|
Could you take a look at it when you have time? :) |
I would just use the same? Not sure why they would be different. Will definitely let Shawn weigh in too, but I can't think of a reason for them using different date formatting. |
Yeah that's my thinking too. I think if you are looking at a date that has a year other than the current year we are in, it should show the year. But if you are looking at a date within the current year, no need to show the year. |
Ok, I asked because I had noticed on the designs that the date text also includes the day name, flight time, etc. and I was wondering if I could apply the same rules for date text displaying which was used for TripRoomPreview. |
Exactly :) |
Spotnana thread for backend updates here: https://expensify.slack.com/archives/C066REXJ9D3/p1713220956933639 |
Chatting about getting the data here: https://expensify.slack.com/archives/C05S5EV2JTX/p1713784714491629?thread_ts=1713545844.230119&cid=C05S5EV2JTX |
@twisterdotcom, @WojtekBoman, @shubham1206agra, @smelaa Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@twisterdotcom, @WojtekBoman, @shubham1206agra, @smelaa Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Update here: https://expensify.slack.com/archives/C05S5EV2JTX/p1714431147318139. Waiting on Spotnana. |
@rushatgabhane has a PR above. |
Updates here - https://expensify.slack.com/archives/C05S5EV2JTX/p1716196862504789?thread_ts=1715723531.626149&cid=C05S5EV2JTX waiting for car pickup address from backend |
@shubham1206agra this is ready for your review. There are a few backend issues here and here but it shouldn't block anything. |
Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
VIP-Travel Implementation Issue
Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.g77lx534xj1g
A new component, TripDetailsView will be created in src/components/ReportActionItem:
Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx
The text was updated successfully, but these errors were encountered: