Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-03] [Guided Setup Stage 2] Create videos #38414

Closed
5 of 10 tasks
francoisl opened this issue Mar 15, 2024 · 36 comments
Closed
5 of 10 tasks

[HOLD for payment 2024-05-03] [Guided Setup Stage 2] Create videos #38414

francoisl opened this issue Mar 15, 2024 · 36 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design Internal Requires API changes or must be handled by Expensify staff Task

Comments

@francoisl
Copy link
Contributor

francoisl commented Mar 15, 2024

Task

For Stage 2 of Guided Setup, we're going to introduce different intro messages and tasks depending on what the user is trying to do in Expensify. The intro message and some of the tasks will have custom videos.

According to the doc, we need:

  • Intent-specific videos:
    • Track business spend for taxes
    • Get paid back by my employer
    • Manage my team's expenses
    • Track and budget personal spend
    • Chat and split bills with friends
  • Task-specific videos:
    • How to track expenses with Expensify
    • How to submit expenses with Expensify
    • How to approve and pay expenses with Expensify
    • How to track personal expenses with Expensify
    • How to chat/split money with friends with Expensify

Extra info

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e8e6232726cb302b
  • Upwork Job ID: 1768697791265419264
  • Last Price Increase: 2024-03-15
@francoisl francoisl added Internal Requires API changes or must be handled by Expensify staff Design Task labels Mar 15, 2024
Copy link

melvin-bot bot commented Mar 15, 2024

Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new.

This comment was marked as resolved.

Copy link

melvin-bot bot commented Mar 15, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

@francoisl
Copy link
Contributor Author

This is all going to be managed internally, no need for a C+ review or Upwork job. Thanks!

@MitchExpensify
Copy link
Contributor

Is TCW handling this or are we?

@dubielzyk-expensify
Copy link
Contributor

We're handling making storyboards then handing over to TCW for making of the final videos/GIFs

@MitchExpensify
Copy link
Contributor

Nice! Where can I follow along?

@dubielzyk-expensify
Copy link
Contributor

Here's the Figma file I'm working from. cc @Expensify/design for viz

@trjExpensify trjExpensify changed the title Create Guided Setup Stage 2 videos [Guided Setup Stage 2] Create videos Mar 21, 2024
@dubielzyk-expensify
Copy link
Contributor

Post made here about updates

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@dubielzyk-expensify
Copy link
Contributor

I'm finishing the intent videos this week. We decided to not go ahead with one-video-per-task, so this should simplify things.

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2024
@barttom
Copy link
Contributor

barttom commented Apr 4, 2024

@dubielzyk-expensify
The new API command for creating messages for guided setup requires a thumbnail for the video. Could You prepare it also for each video?

@dubielzyk-expensify
Copy link
Contributor

Yep, will do! I'm finishing the storyboards today and sending to TCW early next week. Hoping it'll all be done by end of next week basically. Does that fit your timeline?

@dubielzyk-expensify
Copy link
Contributor

Made an update here

@barttom
Copy link
Contributor

barttom commented Apr 5, 2024

Yup, early next week suits me :)
BTW link above doesn't work for me

@dubielzyk-expensify
Copy link
Contributor

Oh sorry. We're just doing a final internal look, then I'll upload them all here 😄

@dubielzyk-expensify
Copy link
Contributor

4 of 5 videos are handed over to TCW here.
Gonna do the last one tomorrow.

Hoping to get the video assets next week. Hope that works with the timeline

@melvin-bot melvin-bot bot added the Overdue label Apr 18, 2024
@dubielzyk-expensify
Copy link
Contributor

Just got back the first draft from TCW. Had only minor feedback. Expect to have the finished videos on Mon-Tue

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2024
@rezkiy37 rezkiy37 mentioned this issue Apr 24, 2024
50 tasks
@trjExpensify
Copy link
Contributor

Making a note here about this discussion. Let's look into why the first frame isn't being displayed as the thumbnail.

Here's a video comparing a video I uploaded and the onboarding video, so you can see the difference:

2024-04-24_13-18-50.mp4

@francoisl
Copy link
Contributor Author

francoisl commented Apr 24, 2024

Also making a note that we need to generate proper thumbnails for the videos, I'll do that after we figure out why no thumbnail is being shown at all.

Edit: done

Copy link

melvin-bot bot commented Apr 25, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rezkiy37
Copy link
Contributor

Hey!
I just wanted to let you know about my vacation for next week. I will be back on 06.05.2024. Meanwhile, I asked @waterim to take over this issue.
See you soon!

@trjExpensify
Copy link
Contributor

I think we're done here though, right?

@rezkiy37
Copy link
Contributor

Looks like yes!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 26, 2024
@melvin-bot melvin-bot bot changed the title [Guided Setup Stage 2] Create videos [HOLD for payment 2024-05-03] [Guided Setup Stage 2] Create videos Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. 🎊

For reference, here are some details about the assignees on this issue:

  • @rezkiy37 does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
Copy link

melvin-bot bot commented May 7, 2024

@francoisl, @rezkiy37, @CherylWalsh, @dubielzyk-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dubielzyk-expensify
Copy link
Contributor

I believe this is done and shipped no?

@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
@rezkiy37
Copy link
Contributor

rezkiy37 commented May 7, 2024

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design Internal Requires API changes or must be handled by Expensify staff Task
Projects
Status: Done
Development

No branches or pull requests

8 participants