New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-03] [Guided Setup Stage 2] Create videos #38414
Comments
Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new. |
This comment was marked as resolved.
This comment was marked as resolved.
Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane ( |
This is all going to be managed internally, no need for a C+ review or Upwork job. Thanks! |
Is TCW handling this or are we? |
We're handling making storyboards then handing over to TCW for making of the final videos/GIFs |
Nice! Where can I follow along? |
Here's the Figma file I'm working from. cc @Expensify/design for viz |
Post made here about updates |
I'm finishing the intent videos this week. We decided to not go ahead with one-video-per-task, so this should simplify things. |
@dubielzyk-expensify |
Yep, will do! I'm finishing the storyboards today and sending to TCW early next week. Hoping it'll all be done by end of next week basically. Does that fit your timeline? |
Made an update here |
Yup, early next week suits me :) |
Oh sorry. We're just doing a final internal look, then I'll upload them all here 😄 |
4 of 5 videos are handed over to TCW here. Hoping to get the video assets next week. Hope that works with the timeline |
Just got back the first draft from TCW. Had only minor feedback. Expect to have the finished videos on Mon-Tue |
Making a note here about this discussion. Let's look into why the first frame isn't being displayed as the thumbnail. Here's a video comparing a video I uploaded and the onboarding video, so you can see the difference: 2024-04-24_13-18-50.mp4 |
Also making a note that we need to generate proper thumbnails for the videos, I'll do that after we figure out why no thumbnail is being shown at all. Edit: done |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Hey! |
I think we're done here though, right? |
Looks like yes! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-03. 🎊 For reference, here are some details about the assignees on this issue:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
@francoisl, @rezkiy37, @CherylWalsh, @dubielzyk-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
I believe this is done and shipped no? |
Yes. |
Task
For Stage 2 of Guided Setup, we're going to introduce different intro messages and tasks depending on what the user is trying to do in Expensify. The intro message and some of the tasks will have custom videos.
According to the doc, we need:
Extra info
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: