Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - Missing avatars and names above IOU preview in main chat after login #38702

Open
6 tasks done
lanitochka17 opened this issue Mar 20, 2024 · 130 comments
Open
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4439905
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User A and B have no prior chat with each other
  • User B must be logged out
  1. Go to staging.new.expensify.com
  2. [User A] Request money from User B
  3. [User B] Log in
  4. [User B] Open 1:1 DM with User A from LHN (or search if it does not show up in LHN)

Expected Result:

The IOU preview in the main chat will show user avatars and names

Actual Result:

The IOU preview in the main chat is missing user avatars and names. It only shows after opening IOU report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6420908_1710960400835.bandicam_2024-03-21_02-41-49-943.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b0f8b90c833a05f3
  • Upwork Job ID: 1771271857156587520
  • Last Price Increase: 2024-05-10
  • Automatic offers:
    • nkdengineer | Contributor | 0
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 20, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 20, 2024

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17 lanitochka17 removed the DeployBlockerCash This issue or pull request should block deployment label Mar 20, 2024
@lanitochka17
Copy link
Author

@yuwenmemon FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@yuwenmemon yuwenmemon added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Hourly KSv2 labels Mar 20, 2024
Copy link

melvin-bot bot commented Mar 20, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@zanyrenney
Copy link
Contributor

added to wave collect.

@zanyrenney
Copy link
Contributor

Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to help while I am OOO.

@zanyrenney zanyrenney removed the Bug Something is broken. Auto assigns a BugZero manager. label Mar 21, 2024
@zanyrenney zanyrenney removed their assignment Mar 21, 2024
@zanyrenney zanyrenney added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 21, 2024
Copy link

melvin-bot bot commented Mar 21, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@adelekennedy
Copy link

adelekennedy commented Mar 22, 2024

@yuwenmemon it looks like the deploy blocker label was added by accident - I'm going to remove you and make this external (this seems like a FE issue to me at first glance - please let me know if you disagree!)

@adelekennedy adelekennedy added External Added to denote the issue can be worked on by a contributor and removed Engineering labels Mar 22, 2024
@melvin-bot melvin-bot bot changed the title IOU - Missing avatars and names above IOU preview in main chat after login [$500] IOU - Missing avatars and names above IOU preview in main chat after login Mar 22, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b0f8b90c833a05f3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 22, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@nkdengineer
Copy link
Contributor

@adelekennedy @youssef-lr we have a draft PR here
@youssef-lr please let me know if PR in Back End is merged

@youssef-lr
Copy link
Contributor

Backend PRs are just waiting to be merged.

@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
Copy link

melvin-bot bot commented May 27, 2024

@eVoloshchak, @youssef-lr, @adelekennedy, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@youssef-lr
Copy link
Contributor

PR still under review. We're discussing a change.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 27, 2024
@adelekennedy
Copy link

adelekennedy commented May 29, 2024

still waiting for the backend prs to be merged

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 29, 2024
@adelekennedy
Copy link

weird - the overdue was cleared and then came right back

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 30, 2024
@adelekennedy
Copy link

adelekennedy commented Jun 3, 2024

@youssef-lr are we holding on this for the merge "slush"?

@melvin-bot melvin-bot bot removed the Overdue label Jun 3, 2024
@youssef-lr
Copy link
Contributor

We missed the deploy window today and we merged a ton of PRs already. I can probably get the PR merged tomorrow.

@youssef-lr
Copy link
Contributor

First backend PR is merged, will merge the 2nd one as soon as it deploys.

@nkdengineer
Copy link
Contributor

@youssef-lr I use staging server and see that childManagerAccountID is correct now. Will we return childOwnerAccountID too in 2nd PR or we will get the ownerAccountID like this : The owner is the other participant who isn't the manager?

@youssef-lr
Copy link
Contributor

I have just merged the 2nd backend PR, once deployed we should have childOwnerAccountID as well

@nkdengineer
Copy link
Contributor

Thanks.

@melvin-bot melvin-bot bot added the Overdue label Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

@eVoloshchak, @youssef-lr, @adelekennedy, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

@eVoloshchak
Copy link
Contributor

Not overdue, waiting for the backend PR to be deployed

@melvin-bot melvin-bot bot removed the Overdue label Jun 11, 2024
@youssef-lr
Copy link
Contributor

backend PR is currently in staging and should hit production soon, @nkdengineer you can ping the C+ for a review of the App PR

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 12, 2024
@nkdengineer
Copy link
Contributor

@eVoloshchak The PR is here cc @youssef-lr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Status: Polish
Development

No branches or pull requests