Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave Collect] [Xero] [Export Flow] Create the Purchase bill date select page #39743

Open
lakchote opened this issue Apr 5, 2024 · 11 comments
Open
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@lschurr
Copy link
Contributor

lschurr commented Apr 5, 2024

Heya @lakchote - Should this be open externally for contributors or is there someone internally working on this?

@lschurr lschurr assigned cubuspl42 and unassigned cubuspl42 Apr 8, 2024
@lschurr
Copy link
Contributor

lschurr commented Apr 8, 2024

SWM will be working on this: https://expensify.slack.com/archives/C036QM0SLJK/p1712343689924329

@lakchote lakchote changed the title [Wave Collect] [Xero] [Export Flow] Create the Purchase bill date select page [HOLD #39735] [Wave Collect] [Xero] [Export Flow] Create the Purchase bill date select page Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2024
@lschurr
Copy link
Contributor

lschurr commented Apr 16, 2024

This is on hold.

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@lakchote
Copy link
Contributor Author

Double-checking with internal engineers, some might be interested to work on this.

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@lschurr
Copy link
Contributor

lschurr commented Apr 29, 2024

Any update here @lakchote? Still on hold?

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
@lakchote lakchote changed the title [HOLD #39735] [Wave Collect] [Xero] [Export Flow] Create the Purchase bill date select page [Wave Collect] [Xero] [Export Flow] Create the Purchase bill date select page Apr 30, 2024
@lakchote
Copy link
Contributor Author

Any update here @lakchote? Still on hold?

Yes, we were on hold for #39725 to be merged.

It was merged yesterday. Technically we are able to work on this now.

I'm going to focus today on fixing the remaining bugs for the Xero authorization flow before working on it.

@trjExpensify
Copy link
Contributor

Merged into the Xero feature branch

@trjExpensify
Copy link
Contributor

Deployed to staging yesterday.

@lakchote
Copy link
Contributor Author

Assigning @rushatgabhane as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes.

@trjExpensify
Copy link
Contributor

Aren't we handling that centrally when wrapping up the project? I agree we should keep this open for the regression period before we close it out though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Release 1.5: XeroCon 2024 (June 12th)
Development

No branches or pull requests

5 participants