[$250] Room - When you assign tasks for member outside private room, we should show a popup inviting them

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.60-13
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): nhut.nguyenminh.it+5000@gmail.com
/ nhut.nguyenminh.it+2@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-condition: A private room, two accounts ( 1 inside room and 1 outside room - we call A and B)

1. Open the app
2. On A Account, access to Private Room
3. Assign a task for B
4. On B, receive a task
5. B tries to action with Task (mark complete ..)

Expected Result:

Same as a GROUP chat function.
When assigning tasks to outside members, a popup invites them to show up, and we can invite them to the room.
After B joined a Room, can see tasks or everything in the room
Before B joins a Room, B can't see a Room in the LHN component.

Actual Result:

Assign tasks for members outside the private room, not show a popup inviting them

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Bug6438926_1712305689797.RScreen_Recording_2024-04-05_at_15.08.31.1.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018bfc480615cf43ae
• Upwork Job ID: 1777344480525914112
• Last Price Increase: 2024-05-07

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[twisterdotcom]

Task bugs are MEDIUM or LOW at the moment. I do think this is a bug, because we should prompt you to invite, even if you agree not to. It's great you can assign tasks outside of private rooms and have somebody complete them back to the private room, but it would be confusing to an end user if they thought that made them a member, which I think is a logical jump.

39799.mp4

cc @quinthar.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018bfc480615cf43ae

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

@izarutskaya In the expected result section you mentioned that we should act the same way as in the group chat. I've checked how the group chat works and it looks like it does all the same, I don't see an invitation popup. Could you please help me to figure out how the expected result should look?

[twisterdotcom]

Like this:

[VickyStash]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assigning tasks to a user outside of the private room doesn't trigger a concierge whisper message with this user invitation.

What is the root cause of that problem?

The API doesn't return an ACTIONABLEMENTIONWHISPER report action for task assignees outside of the room, though it does it for usual mentions of members outside of the room.

What changes do you think we should make in order to solve the problem?

The API should return a report action where actionName is ACTIONABLEMENTIONWHISPER and inviteeAccountIDs has the id of the assignee in case the created task assignee isn't a member of the private room. The FE already supports this type of message, so it should be displayed as expected.

[twisterdotcom]

@hoangzinh let me know how you feel about this proposal.

[hoangzinh]

After B joined a Room, can see tasks or everything in the room
Before B joins a Room, B can't see a Room in the LHN component.

@VickyStash could you share how would you solve those requirements?

[VickyStash]

@hoangzinh I'll try to provide more details here tomorrow, currently working on a higher priority ticket

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[VickyStash]

@hoangzinh I've made more investigations, and that's what I've found. Currently, if user A creates a private room and inside the room creates a task assigned to user B:

1. The task is also sent to the DM between user A and user B. Is it expected to send a task from a private room to the DM as well?
2. Since the task is sent to DM, it's also visible in LHN.
3. User B doesn't have access to a private room and can't see it in the search/LHN options.

The solution depends on whether it's expected to send a task from a private room to the DM.
Here is a video:

TEST_WEB_DESKTOP1.mp4

[hoangzinh]

The task is also sent to the DM between user A and user B. Is it expected to send a task from a private room to the DM as well?

I think it's expected if user B is in that private room.

[twisterdotcom]

It's definitely expected that the task is sent to the DM - the system purposefully allows you to assign tasks to somebody who doesn't have the full context of the room; this is normal for people doing tasks part of a wider process.

We just want to always allow the assigner to invite them there and then because:

1. It makes that step easy
2. It prompts the assigner with the information that this user isn't aware of the full context, meaning they can choose to make them aware or not.

[VickyStash]

@twisterdotcom Got it, thank you for confirming!
But should the assigned user be able to complete the task from DM, if the task was created in a private room and the user wasn't added as a member of this room?
Right now the app shows an error, but the task turns into a completed (though it takes some time for it to be updated):

TASK_TEST1.mp4

Is it expected? Or should we hide the task from DM/LHN if the assigned user wasn't added as a member? Or maybe the error shouldn't be shown?

[jasperhuangg]

I can handle the back-end logic for this, probably some time this week.

[luacmartins]

Thanks @jasperhuangg!

[jasperhuangg]

Have a few local changes, caught up in some higher priority initiatives at the moment.

[jasperhuangg]

Demoting to Weekly, will bring it back to Daily once I can focus more on this.

[melvin-bot]

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[isabelastisser]

Not overdue. @jasperhuangg deprioritized it to weekly. We should have an update soon!

[jasperhuangg]

Just got back from OOO, prioritizing some #fast-apis work over this at the moment in lieu of the merge slush. Will have more updates soon.

[isabelastisser]

not overdue.

[jasperhuangg]

Still haven't gotten around to doing this yet, focusing on #fast-apis work.

[jasperhuangg]

Still haven't gotten around to doing this yet, focusing on #fast-apis work.