Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-22] [$250] [Search v1] Create SearchPage #39880

Closed
luacmartins opened this issue Apr 9, 2024 · 20 comments
Closed

[HOLD for payment 2024-05-22] [$250] [Search v1] Create SearchPage #39880

luacmartins opened this issue Apr 9, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Apr 9, 2024

Section from design doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012c153c59b24c7284
  • Upwork Job ID: 1780007609768833024
  • Last Price Increase: 2024-04-15
@luacmartins luacmartins added the Daily KSv2 label Apr 9, 2024
@luacmartins luacmartins self-assigned this Apr 9, 2024
@luacmartins luacmartins changed the title [Search v1] Create SearchPage [HOLD][Search v1] Create SearchPage Apr 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Apr 14, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2024
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Apr 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD][Search v1] Create SearchPage [$250] [HOLD][Search v1] Create SearchPage Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012c153c59b24c7284

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 15, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 15, 2024
@Kicu
Copy link
Contributor

Kicu commented Apr 18, 2024

@luacmartins since Im very close to being done with SearchFilters and I'd like to take this one next, can you assign me please.

@luacmartins
Copy link
Contributor Author

Done!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 18, 2024
@luacmartins luacmartins changed the title [$250] [HOLD][Search v1] Create SearchPage [$250] [Search v1] Create SearchPage Apr 22, 2024
@luacmartins
Copy link
Contributor Author

@Kicu is still working on ti

@melvin-bot melvin-bot bot removed the Overdue label Apr 23, 2024
@Kicu
Copy link
Contributor

Kicu commented Apr 23, 2024

Just a small comment @luacmartins
According to the design doc most of the Search functionality will be captured within the SearchWidget and the List component. They are responsible for displaying the results, empty state, loading etc.
Furthermore the empty page skeleton PR is already open and navigation + routing is already done and merged.

Because of that I believe this task to be quite simple as it will consist mostly of composing components implemented in other PRs into a nice Page.
I plan to do this one at the very end - this is just connecting together existing blocks. I also expect this will not be a very big issue, even if the name might suggest otherwise.

@luacmartins
Copy link
Contributor Author

Sounds good!

@melvin-bot melvin-bot bot added the Overdue label Apr 25, 2024
@luacmartins
Copy link
Contributor Author

Still in dev

Copy link

melvin-bot bot commented May 3, 2024

@Kicu, @luacmartins, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels May 3, 2024
@luacmartins
Copy link
Contributor Author

This was done as part of #41102 and #41347. Closing.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 15, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Search v1] Create SearchPage [HOLD for payment 2024-05-22] [$250] [Search v1] Create SearchPage May 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2024
Copy link

melvin-bot bot commented May 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @Kicu does not require payment (Contractor)
  • @thesahindia requires payment through NewDot Manual Requests

@thesahindia
Copy link
Member

@luacmartins, can you please add a payment summary so that I can send a money request on ND?

@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label May 27, 2024
Copy link

melvin-bot bot commented May 27, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 27, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 27, 2024
Copy link

melvin-bot bot commented May 27, 2024

Current assignee @bfitzexpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 27, 2024
@luacmartins
Copy link
Contributor Author

Payouts due:

@JmillsExpensify
Copy link

$250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

5 participants