Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Implement offline behavior and error handling for UpdateGroupChatAvatar #39983

Open
marcaaron opened this issue Apr 10, 2024 · 18 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Apr 10, 2024

We are now able to add a custom Group chat avatar. However, we do not handle the failure case yet.

Let's take whatever we are doing for the Profile + Workspace pages and apply the same error handling here.

In the backend, we currently send exceptions like this:

Onyx::handleException($e, 'AD9240FD-A780-425D-B98D-96DD6E4251C1', OnyxKeys::COLLECTION_REPORT.$reportID, ['errorFields', 'avatar']);

Which will put an error field on the report if updating the avatar fails.

We need that error to lead the user back to the avatar and display an error message back to the user.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015da074a9479d6afc
  • Upwork Job ID: 1778152731149742080
  • Last Price Increase: 2024-04-17
  • Automatic offers:
    • s77rt | Reviewer | 0
@marcaaron marcaaron added the NewFeature Something to build that is a new item. label Apr 10, 2024
@marcaaron marcaaron self-assigned this Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@marcaaron
Copy link
Contributor Author

@s77rt first dibs if you want this one before I make it External it's on HOLD for now so no need to respond right away.

@s77rt
Copy link
Contributor

s77rt commented Apr 10, 2024

I'd like to work on this

@marcaaron marcaaron assigned s77rt and sonialiap and unassigned sonialiap Apr 10, 2024
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Apr 10, 2024
@melvin-bot melvin-bot bot changed the title [HOLD PR #39757] Implement offline behavior and error handling for UpdateGroupChatAvatar [$250] [HOLD PR #39757] Implement offline behavior and error handling for UpdateGroupChatAvatar Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015da074a9479d6afc

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 10, 2024
@s77rt
Copy link
Contributor

s77rt commented Apr 15, 2024

No longer on hold. #39757 is merged. Will look into this asap

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@marcaaron marcaaron changed the title [$250] [HOLD PR #39757] Implement offline behavior and error handling for UpdateGroupChatAvatar [$250] Implement offline behavior and error handling for UpdateGroupChatAvatar Apr 16, 2024
@marcaaron
Copy link
Contributor Author

Thanks, removed HOLD here.

Copy link

melvin-bot bot commented Apr 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@s77rt
Copy link
Contributor

s77rt commented Apr 18, 2024

Not overdue. Focused on QBO. Didn't get a chance to work on this yet

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@nexarvo
Copy link
Contributor

nexarvo commented Apr 22, 2024

@marcaaron please assign me this issue (coming from this comment)
cc @s77rt

Copy link

melvin-bot bot commented Apr 22, 2024

@s77rt, @sonialiap, @marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Apr 22, 2024

📣 @nexarvo You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@marcaaron
Copy link
Contributor Author

Sounds good! Thanks everyone. Let's goooo 🙇

@s77rt
Copy link
Contributor

s77rt commented Apr 25, 2024

Not overdue. We have a draft PR

Copy link

melvin-bot bot commented May 22, 2024

This issue has not been updated in over 15 days. @s77rt, @sonialiap, @marcaaron, @nexarvo eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 22, 2024
@s77rt
Copy link
Contributor

s77rt commented May 22, 2024

Melvin, you were supposed to update the issue, didn't you used to say that issues have feeling too.

@marcaaron marcaaron added Weekly KSv2 and removed Monthly KSv2 labels May 23, 2024
@saracouto saracouto added Monthly KSv2 and removed Weekly KSv2 labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants