New tax rate empty state has incorrect label sizes

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Navigate to Workspace > Taxes > Add rate
2. Verify that the input labels have incorrect font size of 13px

Expected Result:

Input labels should have font size of 15px

Actual Result:

Input labels should have font size of 13px

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165be538517a8973a
• Upwork Job ID: 1782835092067209216
• Last Price Increase: 2024-04-23

Issue Owner

Current Issue Owner: @shawnborton

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165be538517a8973a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[luacmartins]

Thanks for the proposal @MahmudjonToraqulov, but we're handling this issue internally!

[MahmudjonToraqulov]

Ok, sorry.

[luacmartins]

@shawnborton did you get a chance to look into this one yet?

[shawnborton]

Not yet!

[shawnborton]

Not overdue, hoping to look at it this week!

[luacmartins]

Shawn will be working on this one!

[shawnborton]

Sorry! Still on my plate, just haven't looked into it yet

[melvin-bot]

@shawnborton, @luacmartins, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[shawnborton]

Still on my plate

[shawnborton]

@luacmartins I think I'm going to need some help with this one!

It looks like we have a component called MenuItemWithTopDescription which seems to have the correct label behavior. But for tax rates, it's using InputWrapper which has some different styles. Anyways, let's plan to look at this during our next mentor sync.

[luacmartins]

@shawnborton you're close! If you look into InputWrapper, we pass an InputComponent prop to it, which is ultimately the input component we render. For the Name field, we are passing TextPicker. Perhaps we can take a look at the styles TextPicker is using?

[melvin-bot]

@shawnborton, @luacmartins, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shawnborton]

Not overdue, still on my plate :)

[melvin-bot]

@shawnborton, @luacmartins, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shawnborton]

No update

[shawnborton]

Maybe today is the day

[melvin-bot]

@shawnborton, @luacmartins, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this?

[shawnborton]

Not overdue, still on my plate