[$250][HOLD #37374] Track expense - Waypoints swap places when tap and hold

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.64-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #40176

Action Performed:

1. Open the App
2. Log in
3. Click on the Global Fab.
4. Press "Track Expense".
5. Click on "Distance" at the top.
6. Add two or more valid waypoints.
7. Swap them around
8. Try tap and hold each waypoint one by one
9. Repeat steps 7 and 8 (If needed)

Expected Result:

All waypoints must stay until moved by user. Behavior should be the same as in Web and mWeb

Actual Result:

Some waypoints swap places when tap and hold

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6459187_1713893255264.Screen_Recording_20240423_194241_New_Expensify__2_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0117efc9769c84fcf4
• Upwork Job ID: 1785733717315878912
• Last Price Increase: 2024-05-22

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

Production:

Record_2024-04-23-21-06-27_4f9154176b47c00da84e32064abf1c48.mp4

[blimpich]

Will look into this this afternoon, have a medical appointment in a bit, but commenting to say this is on my radar for today

[mountiny]

The distance is not yet fully supported in the track expense flow.

cc @neil-marcellini @koko57 for visibility

removing a block as this is a specific ui related issue

[blimpich]

Ah, I see this is related to this new feature #36985 (comment). @neil-marcellini @koko57 I'll defer to you on what you think is best here. Seems frontend specific, so happy to guide this through being marked as external and being solved by contributors if you think that is best here.

[melvin-bot]

@blimpich Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@blimpich Still overdue 6 days?! Let's take care of this!

[blimpich]

Gonna add external to put this one out for contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0117efc9769c84fcf4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[koko57]

@blimpich sorry, I didn't notice your earlier message. As Vit mentioned:

The distance is not yet fully supported in the track expense flow.

I think that should be hold until the track expense fully supports distance, then retested (the problem may not occur anymore after this is done).

cc @neil-marcellini

[blimpich]

I see, is there a tracking issue that we could reference for this issue then? If so I will update the issue title to wait until its resolved before retesting this.

[koko57]

I cc'ed Neil because this should be linked to a BE issue, I don't have an access to the backend issues

[blimpich]

Not overdue

[melvin-bot]

@sakluger, @blimpich, @mallenexpensify, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[koko57]

Still fighting 😅 I've found something that maybe will help me with finally finding the root cause and a solution - When we have more than 2 points the points are swapping only in the range of the swapped elements, I mean when we have 3 points and we swap 2 first points - they are swapped back and the third stays as it is (the whole list is not affected). When we have 5 points and we drag the 1st to be 3rd one, only 3 first items are swapped 4rd and 5th stay as they were. And it's always that the item we want to be the first in a sequence is last and the other are in proper order - like instead 1st, 2nd and 3rd we would get 2nd 3rd and 1st.

[blimpich]

What a bizarre bug 🐛

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[koko57]

Still working on it, Melv

[blimpich]

Assigning @koko57 so that their updates will calm Melvin down

[koko57]

I needed to focus on my other issue to finally open a PR, so I haven't much time to work on this one. Will get back to it on Monday

[melvin-bot]

@sakluger, @blimpich, @mallenexpensify, @koko57, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[blimpich]

Not overdue

[koko57]

I've checked another thing that could be causing it in the code, but it turned out that it's not the culprit. I was wondering if it was working before introducing the New Architecture and I built the project with the New Arch disabled. It turns out that it works as expected. I will look what can we do with that

[koko57]

I'm ooo tomorrow and on Friday, will get back to it next week.

[melvin-bot]

@sakluger, @blimpich, @mallenexpensify, @koko57, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[sakluger]

I'm back, @mallenexpensify I'll unassign you now.

[koko57]

Still working on it

[koko57]

I've checked the behaviour of the draggable flatlist on a clean project - one with our current configuration (rn 0.73.2, gesture handler 2.14.1 and reanimated 3.8.0) and after an upgrade to rm 0.74 (and gesture handler and reanimated upgraded). With our config it was not working well (some elements after drag even disappeared), on the upgraded version it worked, however the glitch that I mentioned for iOS was happening. But ordering was working as expected. As we have the upgrade to 0.74 ongoing, maybe we could hold on this and then work on some additional fixes if they were still necessary.

[blimpich]

@koko57 That sounds good to me! Lets hold on #37374

[sakluger]

Moving to weekly. Based on the hold issue, we may not update for a week or two.