[HOLD for 1:1:1] [NewDot Unapprove] Non-admin approvers aren’t able to Unapprove reports on OldDot

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714131911473989

Action Performed:

Pre-req In OldDot:

• User A (ex. c.dobrzyn+123@expensifail.com): create a Collect with Submit & Approve workspace in OldDot
• User A: Add User C (ex. c.dobrzyn+34@expensifail.com) as a member of the workspace (not admin) > Make User C the Submit & Approve workspace approver

Reproduction Steps:

1. Sign in as User A
2. Submit a report to Users C
3. Sign in as User C
4. Navigate to the report.
5. Approve the report

Expected Result:

Approver in OldDot who is the "Submit and Approve" Approver should be able to Unapproved reports in OldDot (and NewDot when we add Unapprove).

Actual Result:

Approver in OldDot who is the "Submit and Approve" Approver can't Unapproved reports created in NewDot - they can only approve

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014d67da3ebc3f7c4d
• Upwork Job ID: 1784915314907881472
• Last Price Increase: 2024-04-29

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014d67da3ebc3f7c4d

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[Christinadobrzyn]

testing:

test workspace: Testing NonAdmin approver
Owner: c.dobrzyn+123@expensifail.com
Admin: c.dobrzyn+89@expensifail.com
Employee: c.dobrzyn+34@expenisfail.com (Approver in OldDot)

I can't reproduce when submitting to an employee.. trying to submit to a workspace...

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[Christinadobrzyn]

I can't reproduce this, I can't get a report that can be unapproved by anyone in a workspace. I'll keep testing

[Christinadobrzyn]

Okay I think I narrowed down the steps to reproduce in OP - this is going to be internal so adding our labels!

[melvin-bot]

@eVoloshchak, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

trying to get some help here - https://expensify.slack.com/archives/C036QM0SLJK/p1715068029301439

[Christinadobrzyn]

posted in BZ to try and get help - https://expensify.slack.com/archives/C01SKUP7QR0/p1715153127360859

[Christinadobrzyn]

asking Tom for some guidance - https://expensify.slack.com/archives/C036QM0SLJK/p1715068029301439

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the NewFeature assigner, not assigning anyone new.

[garrettmknight]

Discussed in Slack, but this seems like a new behavior from what we can tell. Taking over and setting as a New Feature

[garrettmknight]

Adding to https://github.com/Expensify/Expensify/issues/384891

[Christinadobrzyn]

Oh amazing! Thank you @garrettmknight!

[garrettmknight]

Still holding.