[Help Wanted] Non-admin approvers can change the report workspace for Approved reports on OldDot

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714132204273809

Action Performed:

Pre-req: Setup Collect or Control workspace with Submit & Approve - set the approver as an employee, not an admin.
Action Performed:
Employee A submits a report to Employee B
Employee B approves report
Employee B clicks the details on the Report in OldDot

Expected Result:

• Report workspace should show the actual workspace it’s on
• Report workspace shouldn’t be editable if Employee B isn’t an admin

Actual Result:

• Report workspace shows a list of workspaces Employee B is an admin on, not the workspace the report is on.
• Employee B can change the workspace even though they aren’t an admin on the existing workspace

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.3044.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b52ee6aaf74a66ca
• Upwork Job ID: 1784915027341197312
• Last Price Increase: 2024-04-29

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b52ee6aaf74a66ca

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[strepanier03]

Internal and waiting to be picked up.

[melvin-bot]

@strepanier03, @s77rt Eep! 4 days overdue now. Issues have feelings too...

[strepanier03]

Internal still and waiting to be picked up.

[melvin-bot]

@strepanier03 @s77rt this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03, @s77rt Huh... This is 4 days overdue. Who can take care of this?