Push notifications to a group is using the participants name instead of group's name

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714153790846589

Action Performed:

1. Create a group DM
2. Send a message to the group as a member of the group
3. Get notification in iOS

Expected Result:

Should show the group name

Actual Result:

Showing the user who sent the message

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152f1ef37a9408859
• Upwork Job ID: 1785736553217708032
• Last Price Increase: 2024-05-01

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

@Julesssss @miljakljajic @puneetlath do we want to fix this now or with the notifications project?

[Julesssss]

This is definitely a separate issue. We chose to use participants as the notification title back before group names were a thing.

The expected/current behaviour suggests we'd show the group name instead of sender, but I believe instead we should be showing sender and group name:

Andrew Gable
[Group Name]
Message

[miljakljajic]

Yeah, we've tightened up the initial problem statement to focus on duplicate notifications so this should be handled separately.

[Julesssss]

For whoever picks this up, we just need to update the roomName passed to sendReportCommentNotifications.

@arosiclair has been improving these functions for moneyRequests, so its usage might have changed a little bit.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0152f1ef37a9408859

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[melvin-bot]

@trjExpensify, @sobitneupane, @marcaaron Huh... This is 4 days overdue. Who can take care of this?

[trjExpensify]

PR merged, awaiting a deploy.

[trjExpensify]

Deployed to prod two days ago. @marcaaron that was a Web-E PR, can we close this?

[melvin-bot]

@trjExpensify, @sobitneupane, @marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcaaron]

Thanks, closing it out.