Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QBO] Correct the account type names that are defined as constants #41154

Closed
hayata-suenaga opened this issue Apr 27, 2024 · 3 comments
Closed

[QBO] Correct the account type names that are defined as constants #41154

hayata-suenaga opened this issue Apr 27, 2024 · 3 comments
Assignees
@s77rt @miljakljajic @hayata-suenaga
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Apr 27, 2024 •
edited

The QBO account type string values are incorrect. Fix them.

Screenshot 2024-04-27 at 3 39 34 PM Screenshot 2024-04-27 at 3 40 16 PM Screenshot 2024-04-27 at 3 41 48 PM Screenshot 2024-04-27 at 3 43 40 PM Screenshot 2024-04-27 at 3 44 42 PM
@hayata-suenaga hayata-suenaga added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 27, 2024
@hayata-suenaga hayata-suenaga self-assigned this Apr 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 27, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@hayata-suenaga hayata-suenaga changed the title Correct the account type names that are defined as constants [QBO] Correct the account type names that are defined as constants Apr 27, 2024
@hayata-suenaga hayata-suenaga mentioned this issue Apr 27, 2024
Merged
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Apr 27, 2024
@trjExpensify
Copy link
Contributor

Deployed to prod a couple of days ago. With no C+ on the PR, can we close this?

@hayata-suenaga
Copy link
Contributor Author

yes! I'll close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s77rt s77rt

@miljakljajic miljakljajic

@hayata-suenaga hayata-suenaga

Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
[#whatsnext] #wave-collect
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@trjExpensify @s77rt @miljakljajic @hayata-suenaga