-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-08] App crashes while trying to join public room via deep link #41170
Comments
Triggered auto assignment to @twisterdotcom ( |
Triggered auto assignment to @puneetlath ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this bug might be related to #vip-vsb |
Sometimes I'll get
|
Job added to Upwork: https://www.upwork.com/jobs/~01e9d522b8dfa6acfe |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
@puneetlath and @Ollyws - any idea why this regression is happening? |
@MonilBhavsar are we reverting #40701 - do we need somebody assigned here externally or not? |
@twisterdotcom I think this should be resolved here #41128 |
No, because it didn't cause or reverting it doesn't fix this issue |
Okay, so it's not due to #40701 and @MonilBhavsar doesn't think it's resolved by #41128, so we definitely need to look into this. |
Current assignee @Ollyws is eligible for the Internal assigner, not assigning anyone new. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Tested and it works fine now |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-06. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I don't think @Ollyws needs paying out here, this was reviewed by @puneetlath. @MonilBhavsar or @puneetlath do we need a test here too? I think we already have tests but perhaps we could just use the QA steps from #40701?
|
Yes, looks good 👍 |
Sounds good to me! |
All done |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-08. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Already done. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found validating #40701
Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
The user should be able to join Public rooms via deep link
Actual Result:
in 50/50 times the app crashes in case of use Public room deep link
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6464352_1714307515239.Screen_Recording_2024-04-28_at_15.25.00.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @puneetlath / @twisterdotcomThe text was updated successfully, but these errors were encountered: