[HOLD for payment 2024-06-05] [$250] Task – “Assign to me” missing in list of assignees in task creation flow for Gmail account

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4536728
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:
Go to https://staging.new.expensify.com/

Log in as a user that had previously created tasks.

Click on FAB and select Assign task

Enter title and click next button

Click on Assignee

Expected Result:
“Assign to me” present in the list of assignees in a task creation flow

Actual Result:
“Assign to me” missing in the list of assignees in a task creation flow

Workaround:
unknown

Platforms:
Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence

Bug6468936_1714661275799.Assign_to_me.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[arosiclair]

Reproduced in v1.4.70-0. Doesn't seem to work on prod v1.4.69-2 either. I don't think this is a blocker

[arosiclair]

cc @thienlnam in case you have any context

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016861839d6b10832f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[arosiclair]

Not sure why @MelvinBot nuked the issue description, but the original is in the history

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task – “Assign to me” is sometimes missing in list of assignees in task creation flow.

What is the root cause of that problem?

includeSelfDM is being passed as false.

Also, below check just matches personalDetailsOption.login with currentUserLogin.

App/src/libs/OptionsListUtils.ts

Line 1842 in d03b4b9

let currentUserOption = allPersonalDetailsOptions.find((personalDetailsOption) => personalDetailsOption.login === currentUserLogin);

Thus, check for items in LOGIN_LIST is not happening.

Also, if mobile number is being used as login then also the existing logic would fail.

What changes do you think we should make in order to solve the problem?

includeSelfDM should be passed as true, we can also pass includeThreads as true.

We should use isCurrentUser method which is already defined.

App/src/libs/OptionsListUtils.ts

Lines 833 to 847 in d03b4b9

	function isCurrentUser(userDetails: PersonalDetails): boolean {
	if (!userDetails) {
	return false;
	}
	// If user login is a mobile number, append sms domain if not appended already.
	const userDetailsLogin = PhoneNumber.addSMSDomainIfPhoneNumber(userDetails.login ?? '');
	if (currentUserLogin?.toLowerCase() === userDetailsLogin.toLowerCase()) {
	return true;
	}
	// Check if userDetails login exists in loginList
	return Object.keys(loginList ?? {}).some((login) => login.toLowerCase() === userDetailsLogin.toLowerCase());
	}

Another option will be to check using accountID.

let currentUserOption = allPersonalDetailsOptions.find((personalDetailsOption) => personalDetailsOption.accountID === currentUserAccountID);

[mananjadhav]

Also, if mobile number is being used as login then also the existing logic would fail.

Are you saying this only happens if the user is logged in with mobile number?

[ShridharGoel]

@mananjadhav That will be one of the cases, we are only checking for email as of now (comparing email in session, which is being fetched using ONYX.SESSION key, with user's login). We should check using ONYXKEYS.LOGIN_LIST.

[melvin-bot]

Current assignee @arosiclair is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[cretadn22]

@mananjadhav We additionally require a proper update of the icon, which is missing from @bernhardoj's proposal

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[arosiclair]

@mvtglobally you don't need to retest this anymore

[bernhardoj]

PR is ready

cc: @mananjadhav

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix “Assign to me” missing in list of assignees #42474

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @bernhardoj requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@isabelastisser Can you confirm if there exists a regression test for this one?

@bernhardoj I couldn't find the offending PR caused this to stopped working, can you give it a try?

[bernhardoj]

Hmm, it's hard to track it, maybe it's been there because the code is pretty old, but not very easy to reproduce.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• ROLE: @bernhardoj paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

Payment summary:

C+ Reviewer: @mananjadhav owed $250 via NewDot PENDING
Contributor ROLE: @bernhardoj paid $250 via Upwork.

[isabelastisser]

all set!

[JmillsExpensify]

$250 approved for @mananjadhav