Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processing deferred updates for push notifications causes an infinite loop #41704

Closed
arosiclair opened this issue May 6, 2024 · 5 comments
Closed

Processing deferred updates for push notifications causes an infinite loop #41704

arosiclair opened this issue May 6, 2024 · 5 comments
Assignees
@arosiclair
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@arosiclair
Copy link
Contributor

Repro steps:

  1. Run iOS/Android
  2. Join and mute a room
  3. Kill the app
  4. Send messages in the room to create missed updates
  5. Send a DM to trigger a push notification
  6. Open the app
  7. Infinite loop of GetMissingOnyxMessages
@arosiclair arosiclair added DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 6, 2024
@arosiclair arosiclair self-assigned this May 6, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 6, 2024

Current assignee @arosiclair is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@arosiclair arosiclair mentioned this issue May 6, 2024
Merged
48 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@arosiclair
Copy link
Contributor Author

Fix is merged here: #41702. Going to CP

@github-actions github-actions bot mentioned this issue May 6, 2024
Closed
60 tasks
@luacmartins
Copy link
Contributor

CP done! I think we can check this off.

@arosiclair
Copy link
Contributor Author

Yup on staging now. Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arosiclair arosiclair

Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arosiclair @luacmartins