[Search v1] "__fake__" is displayed at From and To fields for split expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41615

Action Performed:

1. Log in with an expensifail account with at one split expense
2. Navigate to Profile - Troubleshoot - New Search page

Expected Result:

Fields should be populated with valid data

Actual Result:

"fake" is displayed at From and To fields for split expenses

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[roryabraham]

not a blocker - hidden feature

[luacmartins]

@grgia this is still happening. I think the query we have for sharedReports is incorrect

[luacmartins]

I can take this one @roryabraham, since it's related to Search

[roryabraham]

cool

[melvin-bot]

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

Still happening in some instances. I have another PR in review to filter report types and I need to work on another issue for tracked expenses too.

[melvin-bot]

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

I think this should be solved by https://github.com/Expensify/Auth/pull/10927 too, since the reportID used for these split transactions is -2 and we'll filter these out, showing only the 1:1 transactions created from the split.

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Hmm so that PR didn't solve this issue. Gonna work on a separate fix.

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

I think we can close this one for now since the PR was merged. Maybe we'll have another edge case of this issue, but we can reopen it then.