Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on 40768] [$250] Task - Background overlaps task details after deleting task #41825

Closed
1 of 6 tasks
izarutskaya opened this issue May 8, 2024 · 19 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented May 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.71-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4545775
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

  1. Open the app and log in
  2. Open any chat
  3. Assign a task
  4. Open the created task and send a message
  5. Delete the task

Expected Result:

The task details are fully visible

Actual Result:

The background overlaps the task details. The background overlaps briefly thread messages when opening threads in accounts with multiple reports

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6474406_1715132777613.video_2024-05-07_21-45-14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c9e215e05231b823
  • Upwork Job ID: 1788319637053231104
  • Last Price Increase: 2024-05-08
Issue OwnerCurrent Issue Owner: @ahmedGaber93
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

  1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
    • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
  2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
    • You can adjust the urgency of the issue to better represent the gravity of the bug.
    • If the issue is super low priority, feel free to un-assign yourself.
    • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
    • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

@melvin-bot melvin-bot bot removed the Hourly KSv2 label May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Current assignee @madmax330 is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@stephanieelliott I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb

@izarutskaya
Copy link
Author

Production
Screenshot_20240508_145937_New Expensify

@marcaaron
Copy link
Contributor

Gonna demote this one as deleting a task doesn't feel like a super common thing.

This feels similar to another issue here. I'm curious to see if this will be fixed once that goes to staging.

@marcaaron marcaaron added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01c9e215e05231b823

@melvin-bot melvin-bot bot changed the title Task - Background overlaps task details after deleting task [$250] Task - Background overlaps task details after deleting task May 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

@stephanieelliott
Copy link
Contributor

Thanks @marcaaron, I agree -- let's hold on #40768 and then retest once that hits staging.

@stephanieelliott stephanieelliott removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 9, 2024
@stephanieelliott stephanieelliott changed the title [$250] Task - Background overlaps task details after deleting task [HOLD on 40768] [$250] Task - Background overlaps task details after deleting task May 9, 2024
@stephanieelliott stephanieelliott added Weekly KSv2 and removed Daily KSv2 labels May 9, 2024
@stephanieelliott
Copy link
Contributor

Still on hold for #40768

@melvin-bot melvin-bot bot added the Overdue label May 21, 2024
@ahmedGaber93
Copy link
Contributor

ahmedGaber93 commented May 22, 2024

@stephanieelliott the PR #41482 was deployed to production 2 weeks ago. And this issue still reproduced on latest main.

this issue seems has the same root cause as #40078, so I think we can instead colse/hold this on 40078.

@stephanieelliott
Copy link
Contributor

Ah thanks @ahmedGaber93 -- let's hold this on #40078 and retest to see if that fixes it.

@stephanieelliott
Copy link
Contributor

Still holding on #40078

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@madmax330
Copy link
Contributor

not overdue

@ahmedGaber93
Copy link
Contributor

PR #42629 is now in staging

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2024
@stephanieelliott
Copy link
Contributor

^^ Not on staging yet, should be deployed to staging on the next release though!

@ahmedGaber93
Copy link
Contributor

I think we can close this now. #40078 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

5 participants