[HOLD for payment 2024-06-03] [$250] Start chat - No Recent section in Start chat list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/1971079
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account (so that there is no recent list in Sart chat)
3. Open DM with any user
4. Send a message
5. Go to FAB
6. Go to Start chat

Expected Result:

User in Step 3 will appear under Recent section in Start chat list

Actual Result:

There is no Recent section in Start chat list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481504_1715771311261.recent_list.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0124d68db208e5d895
• Upwork Job ID: 1790830447129296896
• Last Price Increase: 2024-05-15

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dangrous]

Yeah seems like a bug unless there was a design change that I'm not aware of (which is possible). I'll make this external but also investigate!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0124d68db208e5d895

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[dangrous]

Looks like #41636 I think

[dangrous]

It looks like we can fix this by updating

App/src/components/OptionListContextProvider.tsx

Line 67 in c7f128b

const newReports = OptionsListUtils.createOptionList({}, reports).reports;

to be:

const newReports = OptionsListUtils.createOptionList(personalDetails, reports).reports;

But I'm not sure if that would cause other issues with the bug that PR was trying to fix. @aldo-expensify @tienifr @c3024 do you mind taking a look?

[tienifr]

I'm going to create a patch PR for this.

[Beamanator]

Fix is in staging and working well!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: missing personal details while creating options list #42238

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests

[jayeshmangwani]

@dangrous We are good close this Issue, It was a regression from a PR, no payments for this issue

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @jayeshmangwani owed $250 via NewDot

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1790830447129296896/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abekkala]

Not sure why Melvin Bot assigned me to process payment

@dangrous We are good close this Issue, It was a regression from a PR, no payments for this issue

[dangrous]

Yeah I think it just is automatic. Will close!