Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-17] [Payment card / Subscription] Integrate failed billing scenarios banner with backend data #42431

Open
amyevans opened this issue May 21, 2024 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@amyevans
Copy link
Contributor

amyevans commented May 21, 2024

Design doc

Issue OwnerCurrent Issue Owner: @miljakljajic
@pasyukevich
Copy link
Contributor

Hi, I'm Eugene from Callstack - expert agency - and I would like to work on this issue.

@amyevans
Copy link
Contributor Author

Not overdue

@pasyukevich
Copy link
Contributor

Today's updates - WIP, implementing utils file to handle all predefined error cases

@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
@pasyukevich
Copy link
Contributor

Today's updates - WIP, implementing utils file to handle all predefined error cases

@pasyukevich
Copy link
Contributor

Today's updates - WIP, still implementing utils file to handle all predefined error cases

@amyevans
Copy link
Contributor Author

Just cross-posting from here so that the message does not get lost: let's ensure to include the RBR implementation for when switching between plans is disallowed (failed UpdateSubscriptionType API command) in this PR

@pasyukevich
Copy link
Contributor

Today's updates - WIP, Utils file is mostly done, remained - to glue logic with buttons, add error cases from failed API commands

@pasyukevich
Copy link
Contributor

For the next two weeks I will be OOO, on Monday will be decided who will continue to work on this task

@amyevans amyevans assigned blimpich and unassigned amyevans Jun 14, 2024
@amyevans
Copy link
Contributor Author

Reassigning to @blimpich since I'm headed out on extended leave after today

@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

Copy link

melvin-bot bot commented Jun 21, 2024

@blimpich, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@blimpich
Copy link
Contributor

Adding @mananjadhav as they'll be the C+ reviewing the PR

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jun 24, 2024

Coming from the PR review and without reading the whole doc, it's really hard to know what the P/S is of this issue. What does it mean to integrate with backend data @blimpich?

The title is also a bit misleading, it's not only integrating with backend (making actual API call). Scope also includes adding this Retry payment button as it's not present yet

@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

@mananjadhav, @blimpich, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mananjadhav
Copy link
Collaborator

Reviewed the PR again sometime back.

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2024
@trjExpensify trjExpensify added the NewFeature Something to build that is a new item. label Jul 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 2, 2024
@trjExpensify
Copy link
Contributor

trjExpensify commented Jul 2, 2024

PR merged yesterday, adding labels to get a BZ assigned.

Copy link

melvin-bot bot commented Jul 2, 2024

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Jul 2, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Integrate failed billing scenarios banner with backend data [HOLD for payment 2024-07-17] [Payment card / Subscription] Integrate failed billing scenarios banner with backend data Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@miljakljajic
Copy link
Contributor

We pay you in ND right @mananjadhav ? So just a payment summary be due for this one on the 17th?

@mananjadhav
Copy link
Collaborator

Yes @miljakljajic that's right.

@miljakljajic
Copy link
Contributor

Thank you!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jul 12, 2024
@miljakljajic
Copy link
Contributor

I'm going to submit the payment summary today as I'm OOO tomorrow - please don't request payment until tomorrow:

@mananjadhav is owed 250 USD for their work reviewing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Release 2: Summer 2024 (Aug)
Development

No branches or pull requests

9 participants