The field border is not red while the error "Please provide a valid Phone Number" is shown on the bottom page

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign in to New Dot with a new account
2. Create a new workspace
3. Connect a new bank account
4. Routing number: 123123123
5. Account Number: 1111222233331111
6. Hit enter. When you're on the Company Information page, input a phone number that's less than 5 digits long.

Expected Result:

Verify that you see the error under the 'phone number' field and that the border of that field turns red.

Actual Result:

The error 'Please provide a valid Phone Number" on the bottom page and the border not red of that field.

Workaround:

Visual

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Failing PR #5938

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[parasharrajat]

I think I am fixing this #5805

[Beamanator]

Hmm in main I don't see this issue, removing DeployBlockerCash and changing priority to Daily till I figure out where / if this was already fixed

[Beamanator]

Aah now I see - when you fill out the entire form before submitting I do reproduce the issue

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

Hmm @mvtglobally in your "Action performed" steps, step 6 says:

6. Hit enter. When you're on the Company Information page, input a phone number that's less than 5 digits long.

But in your screenshot, the phone number has 5 digits. Should we only show the red outline & error text below the "Phone Number" field when the phone number is less than 5 digits? A.k.a. is a 5 digit phone number valid?

[Beamanator]

Looks like the "minimum phone number length" of 5 characters was added by @Luke9389 here: #5938 - about 1 week ago, which is why it's not in staging & production

[Beamanator]

Making not a deploy blocker b/c this issue is about showing the error if a phone number is < 5 characters, which is already working in dev.

@Luke9389 can you confirm this can be closed since it looks like the "Please provide a valid Phone Number" error is from the back-end? (here) Do we expect the phone number field to turn red when the back-end errors are displayed on the front-end?

[Luke9389]

This can indeed be closed. Thanks for the tag 👍