Sign in - Wrong error message is displayed for incorrect 2FA

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log account with 2FA
3. Input correct email
4. Input correct password
5. Enter incorrect 2FA details

Expected Result:

If I enter incorrect 2FA data it should show that I am not entering 2FA correctly

Actual Result:

Wrong message displayed for incorrect 2FA numbers: Incorrect login or password. Please try again

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.34-0
Reproducible in staging?: yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

We can either change the return code on the backend to no longer be 401 or we just make the error more ambiguous. I'll demote since its not a severe problem

[johnmlee101]

Will work on it this week

[johnmlee101]

no update

[johnmlee101]

No update

[johnmlee101]

https://expensify.slack.com/archives/C03TQ48KC/p1647525989751729
made some progress with deciding how to approach this. This will require some backend api changes so this will have to stay internal. Gist is we need to add a flow to Authenticate to give wrong 2FA code errors instead of generic 401s

[johnmlee101]

Gist is we'll need to add logic to Authenticate to throw a slightly different error if it was called with a 2FA code (since it assumes you already have the correct password otherwise it won't show correctly)

This will look identical to SignIn on our API