[HOLD for payment 2022-05-03] iOS/ Android - VBA - Google address suggestion not displayed in the company info and Personal info page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the URL and login
2. Click get started in workspace to add bank account
3. In the company information page enter random number in the company address field

Expected Result:

Google address suggestion displayed for company info and Personal info page for the user to select from

Actual Result:

Google address suggestion not displayed for company info and Personal info page

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1-1- 35.0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5436308_Screen_Recording_20220203-093257_New_Expensify.mp4

Upwork job URL: https://www.upwork.com/jobs/~01f1a686f79d08a031

Issue reported by: Applause @thesahindia
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

I'm pretty sure this is purely front end so we can export the issue but before we do I was curious if you guys wanted to investigate since I see you've worked on this flow before, cc @luacmartins, @aldo-expensify or @Luke9389.

[aldo-expensify]

I also think this is External, this happened to me in IOS

I this the same as https://expensify.slack.com/archives/C01GTK53T8Q/p1643910543271239 and https://expensify.slack.com/archives/C01GTK53T8Q/p1642611684186800 ?

[luacmartins]

I think @aldo-expensify is right and it's because we are rendering a FlatList in a ScrollView. We can mark this as External.

[chiragsalian]

Cool, marking as external. Thanks guys.

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

Job posted to Upwork here: https://www.upwork.com/jobs/~01f1a686f79d08a031

[ahmdshrif]

I try to flow the steps but can't get the page mention.

Screen_Recording_20220208-143808_New.Expensify.mp4

[mananjadhav]

Proposal

I've checked the GooglePlacesAutoComplete documentation and we've done all they've mentioned and it still gives the error. The issue is that the FlatList scroll and the parent ScrollView is in the same direction. There have been work around mentioned to created a VirtualizedView container with FlatList, but I would recommend adding a nested ScrollView in different scroll direction to solve this.

<ScrollView
        style={[styles.mw100, styles.flex1]}
        ref={ref}
        contentContainerStyle={styles.flexGrow1}
        keyboardShouldPersistTaps="handled"
        // eslint-disable-next-line react/jsx-props-no-spreading
        {...props}
        horizontal={false}
    >
        <ScrollView
            horizontal
            contentContainerStyle={[styles.flex1, styles.h100, styles.w100]}
            scrollEnabled={false}
        >
            <View style={[styles.w100]}>
                {props.children}
            </View>
        </ScrollView>
    </ScrollView>
    

Problem with this approach is we would have to recheck styling of all the pages and forms to see if the container overflows.

Update: I've added a child View under the second ScrollView. I missed that we're using a common class FormScrollView across all forms.

[parasharrajat]

Interesting issue.

Problem with this approach is we would have to recheck styling of all the pages and forms to see if the container overflows.

@mananjadhav Could you explain a little bit more about the problem just to make sure I understand it?

[mananjadhav]

@parasharrajat @roryabraham I've added a draft PR and was able to test Web and Desktop but not iOS and Android. I don't get the error anymore but the results don't load up due to CORS. Anyway to get past that for mobile apps?

[roryabraham]

@mananjadhav Did you post the errors you ran into in #expensify-open-source?

[parasharrajat]

You can use any proxy service for testing. Get the proxy url for the api call and pass it to the settings in the component and you should be good to test it.

[mananjadhav]

You can use any proxy service for testing. Get the proxy url for the api call and pass it to the settings in the component and you should be good to test it.

Okay. Thanks for this. I thought there's a might be another way to do it.

Did you post the errors you ran into in #expensify-open-source?

I didn't. I will post it next time, this was more of a question on QA. Thanks for responding.

[laurenreidexpensify]

NB Manan is off for a few days, we'll pick this up again in the draft when he's back

[mananjadhav]

Resuming tomorrow, and will update the PR in a day or two.

[parasharrajat]

@mananjadhav Could you please share the status update?

[laurenreidexpensify]

@mananjadhav any update here?

[mananjadhav]

@laurenreidexpensify PR #8256 is already merged for this issue

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.56-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/nested scroll views google places api #8256

If no regressions arise, payment will be issued on 2022-05-02. 🎊

[laurenreidexpensify]

Just a note - it is a public holiday on 2022-05-02 so I will be issuing payment on 2022-05-03

[laurenreidexpensify]

@thesahindia @parasharrajat @mananjadhav everyone has been paid now 👍🏽

[kavimuru]

This issue is still able to reproduce. Reopening this again.

[laurenreidexpensify]

Working out next steps here (internally)

[laurenreidexpensify]

@kavimuru can you please reopen this as a new issue, and cross reference this one? Thanks!